add "be.focused" and "have.focus" to assertions (#3219) #4274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add "be.focused" to chai_jquery * add comment explaining the mess * add type definitions * refactor assertion to use jquery assertion * remove trailing whitespace * add test for multiple elements, update typedefs * fix failing tests: not.be.visible -> not.exist * allow should(not.be.visible) for failed selectors * remove unrelated visibility changes * extract only focus assertion * Revert "Merge remote-tracking branch 'origin/develop' into issue-97-focus-assertion" This reverts commit b401c32, reversing changes made to ab14758. * force jquery to use custom focus pseudo selector * only force custom matchers for focus selectors * rewrote matchesSelector wrap code * add lodash * Merge in origin/develop * changes on 3.3.0 Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
brian-mann
approved these changes
May 21, 2019
This was referenced May 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this should have been part of 3.3.0, but was left out.
add "be.focused" to chai_jquery
add type definitions
refactor assertion to use jquery assertion
fix #4265
fix #97