Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Extension type] Add more constant constructors tests #2349

Closed
sgrekhov opened this issue Nov 3, 2023 · 2 comments
Closed

[Extension type] Add more constant constructors tests #2349

sgrekhov opened this issue Nov 3, 2023 · 2 comments
Assignees
@sgrekhov
Labels
type-enhancement A request for a change that isn't a bug

Comments

@sgrekhov
Copy link
Contributor

sgrekhov commented Nov 3, 2023

Add tests based on examples from
dart-lang/sdk#53934
dart-lang/sdk#53935
dart-lang/sdk#53936
@sgrekhov sgrekhov added the type-enhancement A request for a change that isn't a bug label Nov 3, 2023
@sgrekhov sgrekhov self-assigned this Nov 3, 2023
@eernstg
Copy link
Member

eernstg commented Nov 3, 2023

Thanks!

sgrekhov added a commit to sgrekhov/co19 that referenced this issue Nov 3, 2023
@sgrekhov
dart-lang#2349. Add more tests for constant constructors of the exten…
c18885f 
…sion types
eernstg pushed a commit that referenced this issue Nov 9, 2023
@sgrekhov
#2349. Add more tests for constant constructors of the extension types (
d7f7514 
#2352)

Add more tests for constant constructors of the extension types.

Co-authored-by: Erik Ernst <eernst@google.com>, fixing a couple of typos.
@sgrekhov
Copy link
Contributor Author

sgrekhov commented Nov 9, 2023

Closing this issue. Added tests for the cases, described in dart-lang/sdk#53935 and dart-lang/sdk#53936
Tests for dart-lang/sdk#53934 will be added as part of #2350

@sgrekhov sgrekhov closed this as completed Nov 9, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 10, 2023
@sgrekhov
[co19] Roll co19 to 306f82e85b3d9e596eed38d36cbef369643515c0
8bcb6ec 
2023-11-10 sgrekhov22@gmail.com dart-lang/co19#2361. Improve some flaky tests on Web (dart-lang/co19#2364)
2023-11-10 sgrekhov22@gmail.com dart-lang/co19#2350. Add more factory constructor tests. Part 3 (dart-lang/co19#2363)
2023-11-09 sgrekhov22@gmail.com dart-lang/co19#2349. Add more tests for constant constructors of the extension types (dart-lang/co19#2352)
2023-11-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2361. Fix flaky tests on web-platforms (dart-lang/co19#2362)
2023-11-08 sgrekhov22@gmail.com dart-lang/co19#2359. Update tests according to the new nullability rules. Part 1 (dart-lang/co19#2360)
2023-11-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2356. Fix return type of `this` (dart-lang/co19#2358)
2023-11-07 sgrekhov22@gmail.com dart-lang/co19#2350. Update existing factory constructor tests. Part 2 (dart-lang/co19#2357)
2023-11-03 sgrekhov22@gmail.com Fixes dart-lang/co19#2339. Add tests that extension can't have name `type` (dart-lang/co19#2340)
2023-11-03 sgrekhov22@gmail.com dart-lang/co19#2346. Add expected error in analyzer (dart-lang/co19#2347)

Change-Id: I6c0e1e9612dc4a0e21c4d506fa682ae1e9b98ea9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335461
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgrekhov sgrekhov

Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgrekhov @eernstg