-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2349. Add more tests for constant constructors of the extension types #2352
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of typos (and one comment about the things being tested, with no requests about changing anything, just reflecting the fact that I was slightly puzzled by the code ;-).
LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t10.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t08.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Extension-types/static_analysis_extension_types_A21_t10.dart
Show resolved
Hide resolved
Typos fixed. Please review |
@eernstg @chloestefantsova friendly ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add missing `)`.
Thank you! |
2023-11-10 sgrekhov22@gmail.com dart-lang/co19#2361. Improve some flaky tests on Web (dart-lang/co19#2364) 2023-11-10 sgrekhov22@gmail.com dart-lang/co19#2350. Add more factory constructor tests. Part 3 (dart-lang/co19#2363) 2023-11-09 sgrekhov22@gmail.com dart-lang/co19#2349. Add more tests for constant constructors of the extension types (dart-lang/co19#2352) 2023-11-09 sgrekhov22@gmail.com Fixes dart-lang/co19#2361. Fix flaky tests on web-platforms (dart-lang/co19#2362) 2023-11-08 sgrekhov22@gmail.com dart-lang/co19#2359. Update tests according to the new nullability rules. Part 1 (dart-lang/co19#2360) 2023-11-07 sgrekhov22@gmail.com Fixes dart-lang/co19#2356. Fix return type of `this` (dart-lang/co19#2358) 2023-11-07 sgrekhov22@gmail.com dart-lang/co19#2350. Update existing factory constructor tests. Part 2 (dart-lang/co19#2357) 2023-11-03 sgrekhov22@gmail.com Fixes dart-lang/co19#2339. Add tests that extension can't have name `type` (dart-lang/co19#2340) 2023-11-03 sgrekhov22@gmail.com dart-lang/co19#2346. Add expected error in analyzer (dart-lang/co19#2347) Change-Id: I6c0e1e9612dc4a0e21c4d506fa682ae1e9b98ea9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335461 Reviewed-by: Erik Ernst <eernst@google.com> Reviewed-by: Alexander Thomas <athom@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
No description provided.