Add currently selected python environment to path for wheel builds #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
reviewed
Mar 26, 2024
| @@ -392,6 +394,7 @@ export class CliWrapper { | |||
| target: string, | |||
| authProvider: AuthProvider, | |||
| workspaceFolder: Uri, | |||
| pythonExtension: MsPythonExtensionWrapper, | |||
There was a problem hiding this comment.
Is the problem with the deploy only? Should we propagate the correct PATH to other bundle commands (like run)?
There was a problem hiding this comment.
Yeah, it is deploy only for now.
ilia-db
reviewed
Mar 26, 2024
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
reviewed
Mar 26, 2024
Co-authored-by: Ilia Babanov <ilia.babanov@databricks.com>
kartikgupta-db
had a problem deploying
to
azure-prod-usr
GitHub Actions
Failure
kartikgupta-db
had a problem deploying
to
azure-prod-usr
GitHub Actions
Failure
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
kartikgupta-db
temporarily deployed
to
azure-prod-usr
GitHub Actions
Inactive
ilia-db
approved these changes
Mar 26, 2024
kartikgupta-db
added a commit
that referenced
this pull request
Apr 3, 2024
## packages/databricks-vscode ## (2024-04-03) * Add currently selected python environment to path for wheel builds (#1159) ([2128013](2128013)), closes [#1159](#1159) * Add extension name to the private preview terms and conditions popup (#1144) ([5370f04](5370f04)), closes [#1144](#1144) * Bump databricks cli to v0.216.0 (#1166) ([fdd0a17](fdd0a17)), closes [#1166](#1166) * Fixes to initialisation UI (#1160) ([77267f4](77267f4)), closes [#1160](#1160) * Ignore stderr for validate and summary commands (#1151) ([3780ec4](3780ec4)), closes [#1151](#1151) * Rename some things (#1146) ([450b002](450b002)), closes [#1146](#1146) * Use packaged CLI if a cli path is not specified in .databrickscfg profile (#1150) ([2cff68e](2cff68e)), closes [#1150](#1150) ## packages/databricks-vscode-types ## (2024-04-03) --------- Co-authored-by: releasebot <noreply@github.com> Co-authored-by: Kartik Gupta <88345179+kartikgupta-db@users.noreply.github.com> Co-authored-by: kartikgupta-db <kartik.gupta@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
PATHenv var for bundle deploy.Tests