Fixes to initialisation UI #1160

kartikgupta-db · 2024-03-26T13:57:15Z

Changes

Welcome view changes

Always show button to create a databricks project.
Don't automatically migrate from old project.json if there are subprojects present.
Reword welcome view buttons and text

Login Changes

Don't logout if refreshing one of the models fails. This means users can see the error, fix it and have their fixes automatically be picked up and tried out.
Show "Multiple login profiles available. Click to select a profile." when multiple profiles found in .databrickscfg.

Tests

ilia-db · 2024-03-26T15:10:18Z

packages/databricks-vscode/src/configuration/ConnectionManager.ts

-                        }
-                    });
-            } else if (e instanceof Error) {
+            if (e instanceof Error) {


With allSettled we are swallowing normal errors right now, we should re-throw them in setTarget/setAuthProvider methods.

But I'm not sure why should we move error handling over there? Seems easier to just have Promise.all and catch everything here. Plus we need to add error handling to ConnectionCommands.selectTarget too.

Removed all settled. I split setting target/auth provider and doing state refresh into 2 separate steps. Now, auth provider and target will still be updated in all models, even if there are some errors. Then, errors are propagated normally from refresh.

ilia-db · 2024-03-26T15:17:25Z

packages/databricks-vscode/src/configuration/ui/ClusterComponent.ts

@@ -105,6 +105,10 @@ export class ClusterComponent extends BaseComponent {
                        new ThemeColor("notificationsErrorIcon.foreground")
                    ),
                    id: TREE_ICON_ID,
+                    command: {


Let's remove the command from the package.json->view/item/context then?

ilia-db · 2024-03-26T15:25:18Z

packages/databricks-vscode/src/configuration/ui/AuthTypeComponent.ts

-            const label = "Login to Databricks";
+            const host = await this.configModel.get("host");
+            if (host === undefined) {
+                return [];


If the bundle doesn't have a host defined we show a "failed to initialize target" notification right now, and then end up in a broken state when you can't really switch target anymore or even trigger the error again.

At least here it would make sense to show a message about the absent host and prompt users to open and update the dabs config

Fixed this state as well. Now we show a message saying "host is misconfigured". And once user fixes it, changes are picked up and processed automatically.

ilia-db · 2024-03-26T15:31:26Z

packages/databricks-vscode/src/configuration/models/ConfigModel.ts

@@ -214,12 +215,32 @@ export class ConfigModel implements Disposable {
            // We want to wait for all the configs to be loaded before we emit any change events from the
            // configStateCache.
            await this.readStateMutex.synchronise(async () => {
-                await Promise.all([
+                await Promise.allSettled([


Is it intentional that we never fail here anymore and always proceed to the setAuthProvider? setAuthProvider doesn't fail too with allSettled, so we are swallowing non-ProcessError errors now, breaking some of the higher-level error handling (in the ConnectionManager and ConnectionCommands)

Yes. The idea is to not block login based on errors here, and also actually run all the promises parallely. I agree that we should show error messages for other errors as well.

Right now, when any of the models fail to refresh, we completely logout, and user has to log back in. With this change, the user can make changes and fixes to their bundle, which will automatically refresh the models and these fixes will then propagate back to the UI

ilia-db · 2024-04-02T09:24:44Z

packages/databricks-vscode/src/configuration/models/ConfigModel.ts

+                this.bundleValidateModel.setTarget(target);
+                this.overrideableConfigModel.setTarget(target);
+                this.bundleRemoteStateModel.setTarget(target);
+                this.onDidChangeTargetEmitter.fire();


I wonder if we now have a race condition because you emit the target change before refreshing the models? During the refresh the connection manager tries to login with saved auth and might use stale values from the configModel (since its refresh is tied to the refreshes of other models, which might not happen in time)

Should we emit the target change at the very end of the method?

Made it emit at the end.

## packages/databricks-vscode ## (2024-04-03) * Add currently selected python environment to path for wheel builds (#1159) ([2128013](2128013)), closes [#1159](#1159) * Add extension name to the private preview terms and conditions popup (#1144) ([5370f04](5370f04)), closes [#1144](#1144) * Bump databricks cli to v0.216.0 (#1166) ([fdd0a17](fdd0a17)), closes [#1166](#1166) * Fixes to initialisation UI (#1160) ([77267f4](77267f4)), closes [#1160](#1160) * Ignore stderr for validate and summary commands (#1151) ([3780ec4](3780ec4)), closes [#1151](#1151) * Rename some things (#1146) ([450b002](450b002)), closes [#1146](#1146) * Use packaged CLI if a cli path is not specified in .databrickscfg profile (#1150) ([2cff68e](2cff68e)), closes [#1150](#1150) ## packages/databricks-vscode-types ## (2024-04-03) --------- Co-authored-by: releasebot <noreply@github.com> Co-authored-by: Kartik Gupta <88345179+kartikgupta-db@users.noreply.github.com> Co-authored-by: kartikgupta-db <kartik.gupta@databricks.com>

kartikgupta-db added 4 commits March 26, 2024 11:55

wip

295d983

wip

4e73880

better login message

ebff675

better login message

ca4f360

kartikgupta-db requested a review from ilia-db March 26, 2024 13:57

kartikgupta-db had a problem deploying to azure-prod-usr March 26, 2024 13:57 — with GitHub Actions Failure

ilia-db reviewed Mar 26, 2024

View reviewed changes

reset cache on target change

e589412

kartikgupta-db had a problem deploying to azure-prod-usr March 28, 2024 10:51 — with GitHub Actions Failure

test fix

d91903e

kartikgupta-db temporarily deployed to azure-prod-usr March 28, 2024 10:54 — with GitHub Actions Inactive

kartikgupta-db requested a review from ilia-db March 28, 2024 10:57

ilia-db reviewed Apr 2, 2024

View reviewed changes

adress feedback

dc5cdbd

kartikgupta-db temporarily deployed to azure-prod-usr April 3, 2024 13:13 — with GitHub Actions Inactive

kartikgupta-db requested a review from ilia-db April 3, 2024 13:31

ilia-db approved these changes Apr 3, 2024

View reviewed changes

kartikgupta-db merged commit 77267f4 into bundle-integ Apr 3, 2024
3 checks passed

kartikgupta-db deleted the welcome-views branch April 3, 2024 13:36

github-actions bot mentioned this pull request Apr 3, 2024

Release: v2.0.2-preview #1167

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes to initialisation UI #1160

Fixes to initialisation UI #1160

kartikgupta-db commented Mar 26, 2024

ilia-db Mar 26, 2024

kartikgupta-db Mar 28, 2024 •

edited

Loading

ilia-db Mar 26, 2024

ilia-db Mar 26, 2024

kartikgupta-db Mar 28, 2024

ilia-db Mar 26, 2024

kartikgupta-db Mar 27, 2024 •

edited

Loading

ilia-db Apr 2, 2024 •

edited

Loading

ilia-db Apr 2, 2024

kartikgupta-db Apr 3, 2024 •

edited

Loading

Fixes to initialisation UI #1160

Fixes to initialisation UI #1160

Conversation

kartikgupta-db commented Mar 26, 2024

Changes

Welcome view changes

Login Changes

Tests

ilia-db Mar 26, 2024

Choose a reason for hiding this comment

kartikgupta-db Mar 28, 2024 • edited Loading

Choose a reason for hiding this comment

ilia-db Mar 26, 2024

Choose a reason for hiding this comment

ilia-db Mar 26, 2024

Choose a reason for hiding this comment

kartikgupta-db Mar 28, 2024

Choose a reason for hiding this comment

ilia-db Mar 26, 2024

Choose a reason for hiding this comment

kartikgupta-db Mar 27, 2024 • edited Loading

Choose a reason for hiding this comment

ilia-db Apr 2, 2024 • edited Loading

Choose a reason for hiding this comment

ilia-db Apr 2, 2024

Choose a reason for hiding this comment

kartikgupta-db Apr 3, 2024 • edited Loading

Choose a reason for hiding this comment

kartikgupta-db Mar 28, 2024 •

edited

Loading

kartikgupta-db Mar 27, 2024 •

edited

Loading

ilia-db Apr 2, 2024 •

edited

Loading

kartikgupta-db Apr 3, 2024 •

edited

Loading