Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

fix: exclude defaultSchemaLocations in offline k8s validation #643

Merged
merged 15 commits into from
May 25, 2022
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: make checkIsOffline a static method
  • Loading branch information
royhadad committed May 25, 2022
commit 62da94ccf67da3935bfca68d76c620c50038cf8e
4 changes: 2 additions & 2 deletions bl/validation/k8sValidator.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,12 @@ func New() *K8sValidator {
}

func (val *K8sValidator) InitClient(k8sVersion string, ignoreMissingSchemas bool, userProvidedSchemaLocations []string) {
val.isOffline = val.checkIsOffline()
val.isOffline = checkIsOffline()
val.areThereCustomSchemaLocations = len(userProvidedSchemaLocations) > 0
val.validationClient = newKubeconformValidator(k8sVersion, ignoreMissingSchemas, getAllSchemaLocations(userProvidedSchemaLocations, val.isOffline))
}

func (val *K8sValidator) checkIsOffline() bool {
func checkIsOffline() bool {
client := http.Client{
Timeout: 10 * time.Second,
}
Expand Down