This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
fix: exclude defaultSchemaLocations in offline k8s validation #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
royhadad
changed the title
royhadad
force-pushed
the
add_offline_check_in_k8s_validator
branch
6 times, most recently
from
b61ab2f
to
65e3952
Compare
royhadad
force-pushed
the
add_offline_check_in_k8s_validator
branch
from
65e3952
to
46b341d
Compare
dimabru
approved these changes
May 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use cases:
offline mode:
uses only the schema locations provided by the user
--schema-locationprovided: skips k8s validation with warning--schema-locationprovided: validates normally--schema-locationprovided: will fail because of no internet and display the error message in the correct formatonline mode:
gives precedence to schema locations provided by the user, uses Datree's default schema locations as a fallback