Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screensharing in 2.9 doesn't work #71

Closed
ddvk opened this issue Sep 20, 2021 · 5 comments
Closed

Screensharing in 2.9 doesn't work #71

ddvk opened this issue Sep 20, 2021 · 5 comments

Comments

@ddvk
Copy link
Owner

ddvk commented Sep 20, 2021

First discussed here, ddvk/remarkable-hacks#344
The updates don't seem to work with rm2fb_client even with the unmodified xochitl binary ...

@timower
Copy link
Collaborator

timower commented Sep 20, 2021

I saw this when looking in ghidra. We hook the update function of the xochitl app, which contains the logic to send the screen update to screensharing.

The server xochitl does have an unhooked version of the update function but there the screen sharing function hasn't been started.

We should probably activate the screen sharing update signal in our hooked update function.

@ddvk
Copy link
Owner Author

ddvk commented Sep 20, 2021

which one is the rfb update?

@robfreundlich
Copy link

We should probably activate the screen sharing update signal in our hooked update function.

Yes, please! There are many toltec packages that I'd like to use, but they all depend on this one. So it's a Hobson's Choice - screen sharing or the toltec packages.

@Jayy001
Copy link

Jayy001 commented Oct 21, 2022

Any update on this?

ddvk added a commit that referenced this issue Nov 17, 2022
hook the notify function for the screenshare #71
@ddvk
Copy link
Owner Author

ddvk commented Nov 20, 2022

marking as fixed

@ddvk ddvk closed this as completed Nov 20, 2022
NeilInnes added a commit to NeilInnes/toltec that referenced this issue Dec 6, 2022
Fixes bug with Remarkable desktop app screen share freezing (ddvk/remarkable2-framebuffer#71)
Eeems added a commit to toltec-dev/toltec that referenced this issue Feb 12, 2023
* Update display and rm2fb-client to v0.0.28

Fixes bug with Remarkable desktop app screen share freezing (ddvk/remarkable2-framebuffer#71)

* Update rm2fb to v0.0.29

---------

Co-authored-by: Nathaniel van Diepen <Eeems@users.noreply.github.com>
Eeems added a commit to toltec-dev/toltec that referenced this issue Feb 28, 2023
* Update display and rm2fb-client to v0.0.28

Fixes bug with Remarkable desktop app screen share freezing (ddvk/remarkable2-framebuffer#71)

* Update rm2fb to v0.0.29

---------

Co-authored-by: Nathaniel van Diepen <Eeems@users.noreply.github.com>
Eeems added a commit to toltec-dev/toltec that referenced this issue Mar 7, 2023
* Update KOReader to v2022.11 (#659)

* Update oxide to v2.5 (#662)

Update the following applications to 2.5:
- erode
- fret
- oxide
- rot
- tarnish
- decay
- corrupt
- anxiety
- liboxide
Update libsentry to 0.5.0
Add new notify-send package

* Add package: webinterface-wifi (#664)

* Add package: webinterface-wifi

---------

Co-authored-by: Nathaniel van Diepen <Eeems@users.noreply.github.com>

* Add package: neofetch (#665)

* Update KOReader to v2023.01 (#663)

* Update display and rm2fb-client to v0.0.29 (#656)

* Update display and rm2fb-client to v0.0.28

Fixes bug with Remarkable desktop app screen share freezing (ddvk/remarkable2-framebuffer#71)

* Update rm2fb to v0.0.29

---------

Co-authored-by: Nathaniel van Diepen <Eeems@users.noreply.github.com>

* Update rm2fb to v0.0.30 (#666)

Fix crash due to invalid notify address for 3.0.4.1305.

---------

Co-authored-by: rM-self-serve <122753594+rM-self-serve@users.noreply.github.com>
Co-authored-by: Neil Innes <neil.innes@visualsoft.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants