Skip to content

Commit

Permalink
perf(ext/fetch): improve decompression throughput by upgrading `tower…
Browse files Browse the repository at this point in the history
…_http` (#25806)

This commit improves the throughput when a Deno process is running as a proxy
server that deals with compressed data from the upstream server.

We have seen a performance degradation since v1.45.3 when we run a HTTP server
with Deno with a particular setting, where it fetches _compressed_ data from the
upstream server and forwards it to the end client. After some investigation, it
turned out that [tower_http::decompression] causes this issue, which was fixed
by the new version of this crate, v0.6.1.

[tower_http::decompression]: https://docs.rs/tower-http/0.6.0/tower_http/decompression/index.html

Fixes #25798
  • Loading branch information
magurotuna authored Sep 24, 2024
1 parent 1eebd20 commit d8036ab
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
8 changes: 4 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@ tokio-rustls = { version = "0.26.0", default-features = false, features = ["ring
tokio-socks = "0.5.1"
tokio-util = "0.7.4"
tower = { version = "0.4.13", default-features = false, features = ["util"] }
tower-http = { version = "0.5.2", features = ["decompression-br", "decompression-gzip"] }
tower-http = { version = "0.6.1", features = ["decompression-br", "decompression-gzip"] }
tower-lsp = { package = "deno_tower_lsp", version = "0.1.0", features = ["proposed"] }
tower-service = "0.3.2"
twox-hash = "=1.6.3"
Expand Down

0 comments on commit d8036ab

Please sign in to comment.