Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ext/fetch): improve decompression throughput by upgrading tower_http #25806

Conversation

magurotuna
Copy link
Member

Fixes #25798

This accomplishes the same result as #25800, but not by manually implementing a decompression logic, but by upgrading tower-http to incorporate the patch (tower-rs/tower-http#521).

performance comparison

Copy link
Member

@satyarohith satyarohith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc @bartlomieju

@bartlomieju
Copy link
Member

Let's wait a couple hours, @seanmonstar is preparing a release of tower_http so we won't have to use a patch.

@seanmonstar
Copy link
Contributor

See: tower-rs/tower-http#522

@seanmonstar
Copy link
Contributor

tower-http v0.6.1 is released.

@magurotuna magurotuna force-pushed the magurotuna/perf-fetch-decompression-by-tower-http-fix branch from 4f2e35f to f55b190 Compare September 23, 2024 16:11
@magurotuna
Copy link
Member Author

with tower-http v0.6.1

Just to be sure, I confirmed that tower-http v0.6.1 improves the performance.

@magurotuna magurotuna merged commit d8036ab into denoland:main Sep 24, 2024
17 checks passed
@magurotuna magurotuna deleted the magurotuna/perf-fetch-decompression-by-tower-http-fix branch September 24, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Throughput of proxying compressed data with fetch and Deno.serve has deteriorated
5 participants