Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracking: Some modules cannot be marked as "browser compatible" because of outdated TS library types #1973

Open
1 of 3 tasks
jsejcksn opened this issue Mar 1, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@jsejcksn
Copy link
Contributor

jsejcksn commented Mar 1, 2022

Context

The current browser compatibility CI test uses TypeScript's native DOM types when type-checking modules. This is appropriate.

However, the current DOM types appear to be outdated (technically, misaligned from what's being commonly shipped by browsers), so it's not possible to get tests to pass for some modules which actually are compatible in that sense.

Problem

The above described scenario prevents marking some modules as being "browser compatible" and prevents their discovery as such. I've included links to examples at the end of this message.

Candidate modules, grouped by related compiler diagnostic:

@jsejcksn jsejcksn added bug Something isn't working needs triage labels Mar 1, 2022
@kt3k kt3k added enhancement New feature or request and removed bug Something isn't working needs triage labels Mar 1, 2022
@jsejcksn
Copy link
Contributor Author

jsejcksn commented Mar 5, 2022

@crowlKats I don't see any activity at all in the TS repo which mentions ReadableByteStreamController. Am I missing something or should we file an issue?

@crowlKats
Copy link
Member

yep, we probably should. Major missing structs are ReadableByteStreamController & ReadableStreamBYOBReader

@jsejcksn jsejcksn changed the title Some modules cannot be marked as "browser compatible" because of outdated TS DOM types tracking: Some modules cannot be marked as "browser compatible" because of outdated TS library types Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants