-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: mark modules as browser compatible #1972
Conversation
Are there even more that can be included in this PR? |
@jsejcksn |
@crowlKats It appears that the
|
Then TS' typings are outdated. async iter on readablestream is part of spec |
@crowlKats I understand and agree, but the tests still fail and prevent inclusion until TS updates its DOM types. |
Oh well, then we can skip on that one for now |
The same TS typings problem exists for uuid v4:
|
This PR turned out to be a bit bigger than I initially anticipated. Please review and let me know if I overlooked anything: thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, we have many compatible modules! Nice work! @jsejcksn
@crowlKats Is there a "todo" list in this repo's files/issues/etc. where the outdated DOM types issues mentioned above can be noted for revisiting after a future update to the TS DOM lib? |
@jsejcksn I don't think we have such issue |
@kt3k Can one be created? (Perhaps using the projects or wiki features if an issue is not appropriate — I realize many orgs don't leave issues open which are not yet actionable. However, it seems very useful to record this information in a way that increases the likelihood of its being seen again to be revisited.) |
@jsejcksn I think issue is the best for tracking it. Would you mind creating one? |
@kt3k Done |
@jsejcksn Thanks! Nice! |
Modified the above issue a little bit, and made the remaining items into todo list (in github md notation). Feel free to edit them if you find any new items |
@kt3k I updated it again to sort at the top level by incompatible types, with affected modules listed under each, including links to the latest relevant lines in the TS DOM lib files. |
These modules are useful in browser environments.