Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: streams based Buffer #1970

Merged
merged 2 commits into from
Mar 5, 2022
Merged

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Feb 28, 2022

Equivalent of std/io/buffer.ts's Buffer but with streams

@bartlomieju
Copy link
Member

What's the use case for this? Why create a new class with the same name instead of adding this functionality to existing Buffer?

@crowlKats
Copy link
Member Author

@bartlomieju well, we want various Deno.Reader/Writer based APIs to be written/ported to streams. These should be in their own file so there in no dependency on the aforementioned APIs

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsejcksn
Copy link
Contributor

jsejcksn commented Mar 4, 2022

What's the use case for this? Why create a new class with the same name instead of adding this functionality to existing Buffer?

@crowlKats Does this also allow for browser compatibility? If so, please mark it as such.

@crowlKats
Copy link
Member Author

@jsejcksn nope, once again, typescript is behind the times with outdated typings

@jsejcksn
Copy link
Contributor

jsejcksn commented Mar 5, 2022

@jsejcksn nope, once again, typescript is behind the times with outdated typings

@crowlKats There's a tracking issue for compat issues caused by outdated native TS types here. Will you add any candidate modules there?

@crowlKats
Copy link
Member Author

@jsejcksn done

@crowlKats crowlKats merged commit 5502575 into denoland:main Mar 5, 2022
@crowlKats crowlKats deleted the streams_buffer branch March 5, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants