-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Snapshots break after Deno 1.33.2 #3404
Comments
I agree that the previous version was better for comparing snapshots. This was caused by this change in Deno CLI denoland/deno#18691 (We aligned @crowlKats Do you know if there's any option to restore the previous behavior for long string values? Or the previous behavior is gone now? |
i believe the previous behaviour is completely gone, and would potentially be quite involved to bring back afaik |
For denoland/std#3404 --------- Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
For denoland/std#3404 --------- Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
Describe the bug
Deno 1.33.2 changed the way to serialize multiline strings and, instead of a single string, it returns a concatenation of several strings, one per line. This makes all tests to fail:
Steps to Reproduce
Expected behavior
The solution is update the snapshots with
-- --update
(obviously), but I think the previous format was much clearer to see the difference between two snapshots.Environment
The text was updated successfully, but these errors were encountered: