BREAKING(testing/snapshot): fix regression of serialization of long strings #3507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, thanks a lot for this!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the snapshots of long strings are split into additions of smaller string, and those are very hard to read as pointed in #3404. This behavior is unintentionally introduced by the merge of
Deno.inspectandutil.inspect(Node compat). ref: denoland/deno#18691This PR uses
breakLength: Infinityoption ofDeno.inspect(which was added in denoland/deno#19337), and restores the original behavior.fixes #3404
cc @oscarotero