Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(path): release path@1.0.0-rc.1 #4951

Merged
merged 2 commits into from
Jun 5, 2024
Merged

chore(path): release path@1.0.0-rc.1 #4951

merged 2 commits into from
Jun 5, 2024

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Jun 4, 2024

Toward #4922

@iuioiua iuioiua requested a review from kt3k as a code owner June 4, 2024 03:48
@github-actions github-actions bot added the path label Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (a2af1d0) to head (dcbdcb6).
Report is 1 commits behind head on main.

Current head dcbdcb6 differs from pull request most recent head f012724

Please upload reports for the commit f012724 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4951   +/-   ##
=======================================
  Coverage   92.17%   92.18%           
=======================================
  Files         487      487           
  Lines       38732    38765   +33     
  Branches     5386     5394    +8     
=======================================
+ Hits        35702    35734   +32     
- Misses       2974     2975    +1     
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -39,7 +39,7 @@
"@std/media-types": "jsr:@std/media-types@^1.0.0-rc.1",
"@std/msgpack": "jsr:@std/msgpack@^0.224.2",
"@std/net": "jsr:@std/net@^0.224.2",
"@std/path": "jsr:@std/path@^0.225.2",
"@std/path": "jsr:@std/path@1.0.0-rc.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kt3k
Copy link
Member

kt3k commented Jun 4, 2024

Let's land this first and keep discussing #4954 during RC (Breaking changes during RC versions are common practice to my knowledge).

@iuioiua
Copy link
Collaborator Author

iuioiua commented Jun 5, 2024

Frankly, breaking changes during the release candidate phase seems to conflict with the objective of a release candidate, and I disagree with it. Nevertheless, I'm merging this PR so we can progress with stabilization.

@iuioiua iuioiua merged commit 7085c94 into main Jun 5, 2024
10 checks passed
@iuioiua iuioiua deleted the path-rc-1 branch June 5, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants