BREAKING(path): remove runtime type-checking

[iuioiua]

What's changed

This change removes assertPath() and its use from @std/path.

Why was this change made?

assertPath() was an internal function that checked whether a provided string was a string (see implementation). In other words, it could catch an incorrectly typed variable when either not using TypeScript or bypassing the type-checker. In most environments, this function wasn't useful. Hence, the removal.

While the topic of runtime type-checking is still being discussed in #3888, this change was made to be consistent with the rest of the Standard Library in the meantime, which doesn't perform initial type-checking of arguments.

Migration guide

If using an environment that doesn't use TypeScript or bypasses the type-checker, and if needed, check that variables passed to @std/path API are the correct type manually.

Related

• discussion: runtime type-checking #3888
• refactor(path): cleanup join() implementations #4946 (comment)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.18%. Comparing base (cfb169e) to head (49fd253).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4954   +/-   ##
=======================================
  Coverage   92.18%   92.18%           
=======================================
  Files         487      486    -1     
  Lines       38751    38714   -37     
  Branches     5395     5394    -1     
=======================================
- Hits        35721    35688   -33     
+ Misses       2974     2970    -4     
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kt3k]

There seems no consensus reached in #3888. I'd suggest we should discuss this after the stabilization.

[iuioiua]

We should be consistent in the meantime. We can come to a decision for the codebase as a whole later, right?

[kt3k]

As I commented in #4946 (comment), there isn't such consistency in std.