fix: fix bug in retrieving the caller in the set_config endpoint. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: When calling the set_config API, the following error is returned: ``` "ic0_msg_caller_size" cannot be executed in reply callback mode ``` The reason here is that the caller is fetched after making an async request, which is not something that we allow. Solution: Store the caller in a variable before making the async request.
|
LGTM. |
dragoljub-duric
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When calling the set_config API, the following error is returned:
The reason here is that the caller is fetched after making an async request, at which point it becomes unavailable.
Solution:
Store the caller in a variable before making the async request.