Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix bug in retrieving the caller in the set_config endpoint. #157

Merged
merged 3 commits into from
Mar 23, 2023
Merged

fix: fix bug in retrieving the caller in the set_config endpoint. #157

merged 3 commits into from
Mar 23, 2023

Commits on Mar 22, 2023

  1. fix: fix bug in retrieving the caller in the set_config endpoint. 

    Problem:
When calling the set_config API, the following error is returned:

```
"ic0_msg_caller_size" cannot be executed in reply callback mode
```

The reason here is that the caller is fetched after making an async
request, which is not something that we allow.

Solution:
Store the caller in a variable before making the async request.
    @ielashi
    ielashi committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    a51f998 View commit details
    Browse the repository at this point in the history

  2. shellcheck

    @ielashi
    ielashi committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    30c0bdd View commit details
    Browse the repository at this point in the history

  3. add new e2e test to ci

    @ielashi
    ielashi committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    f551f3a View commit details
    Browse the repository at this point in the history