Skip to content

Commit

Permalink
Add accelerator keys to create new session tabs
Browse files Browse the repository at this point in the history
Auditors: @clifton

Test Plan:

  1. Ensure 'File > New Session Tab' sub-entries have accelerator labels
  2. Ensure new sub-entries menu items create session tabs
  3. Ensure accelerator keys for new session tabs work as expected

Fixes: brave#10363
  • Loading branch information
aekeus authored and dfperry5 committed Aug 18, 2017
1 parent c52a62d commit dc645ec
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions app/common/commonMenu.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ module.exports.newPrivateTabMenuItem = () => {
module.exports.newPartitionedTabMenuItem = () => {
const newPartitionedMenuItem = (partitionNumber) => ({
label: `${locale.translation('newSessionTab')} ${partitionNumber}`,
accelerator: 'CmdOrCtrl+Alt+' + partitionNumber,
click: (item, focusedWindow) => {
ensureAtLeastOneWindow({
partitionNumber
Expand Down

0 comments on commit dc645ec

Please sign in to comment.