Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add accelerator keys for new session tab menu entries #10363

Open
aekeus opened this issue Aug 9, 2017 · 2 comments
Open

Add accelerator keys for new session tab menu entries #10363

aekeus opened this issue Aug 9, 2017 · 2 comments
Assignees
@aekeus
Labels
feature/keyboard-shortcuts feature/session-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
Triage Backlog

Comments

@aekeus
Copy link
Member

aekeus commented Aug 9, 2017 •
edited by luixxiul
Loading

Test plan

#10364 (comment)

New sessions may be created by selecting from the sub-menu. There is currently no convenient keyboard shortcut for this task.

The accelerator keys should be CmdOrCtrl+Alt+{PartitionNumber}.
@aekeus aekeus added this to the 0.20.x (Developer Channel) milestone Aug 9, 2017
@aekeus aekeus self-assigned this Aug 9, 2017
aekeus added a commit that referenced this issue Aug 9, 2017
@aekeus
Add accelerator keys to create new session tabs
dff2bc7 
Auditors: @clifton

Test Plan:

  1. Ensure 'File > New Session Tab' sub-entries have accelerator labels
  2. Ensure new sub-entries menu items create session tabs
  3. Ensure accelerator keys for new session tabs work as expected

Fixes: #10363
@aekeus aekeus mentioned this issue Aug 9, 2017
Merged
8 tasks
dfperry5 pushed a commit to dfperry5/browser-laptop that referenced this issue Aug 18, 2017
@aekeus @dfperry5
Add accelerator keys to create new session tabs
dc645ec 
Auditors: @clifton

Test Plan:

  1. Ensure 'File > New Session Tab' sub-entries have accelerator labels
  2. Ensure new sub-entries menu items create session tabs
  3. Ensure accelerator keys for new session tabs work as expected

Fixes: brave#10363
This was referenced Dec 20, 2017
Closed
Closed
@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
@eljuno eljuno mentioned this issue Feb 2, 2018
Closed
@petemill
Copy link
Member

petemill commented Feb 6, 2018 •
edited
Loading

Re-opening due to #12956. The shortcut alt(gr)+number, which was implemented to fix this issue in #10364 is used (on Windows at least) to insert special characters, such as @ or $ or £, and will be reverted so that users can input these characters once more.

@petemill petemill reopened this Feb 6, 2018
@eljuno eljuno mentioned this issue Feb 6, 2018
Closed
@vinicentus
Copy link

Just noticed the reopening. Take a look at #13015.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aekeus aekeus

Labels
feature/keyboard-shortcuts feature/session-tabs QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
Triage Backlog
Development

No branches or pull requests
8 participants
@aekeus @petemill @luixxiul @bsclifton @srirambv @vinicentus @cndouglas @LaurenWags