fix: add scroll for workflows [DHIS2-15415] #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-276--dhis2-data-approval.netlify.app |
tomzemp
commented
Jun 26, 2023
| const now = new Date() | ||
| const yearTwoYearsAgo = now.getFullYear() - 2 | ||
| return () => | ||
| jest.requireActual('moment')(`${yearTwoYearsAgo}-01-01T00:00:00.000Z`) |
There was a problem hiding this comment.
There is a test that expects output of Approved by Hendrik 2 years ago. However, since the date here was fixed as 01-01-01T00:00:00.000 when I ran the test now in 2023, I got the output of Approved by Hendrik 3 years ago.
This update just sets it so the date will be 1 January two years prior to the current year, so that the output text should always be Approved by Hendrik 2 years ago.
tomzemp
commented
Jun 26, 2023
| @@ -3,3 +3,7 @@ | |||
| color: var(--colors-grey700); | |||
| padding: var(--spacers-dp16) var(--spacers-dp8) var(--spacers-dp24); | |||
| } | |||
| .menu { | |||
| max-height: 70vh; | |||
There was a problem hiding this comment.
as noted in the PR description, this is just a random value I chose as the other two drop downs were already different.
Birkbjo
approved these changes
Aug 7, 2023
helladawit
approved these changes
Aug 8, 2023
|
🎉 This PR is included in version 100.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds overflow-y and sets max height for workflow menu. See https://dhis2.atlassian.net/jira/software/c/projects/DHIS2/issues/DHIS2-15415. The other selectors (for period and organisation unit) have differing fixed max-heights, so I just somewhat randomly went with .7vh here 🫤.
Note:
There were a number of tests that were failing when I went to make this update. The tests aren't failing because of the changes I've made (the stylistic changes don't affect anything, particularly for our testing where admin user only has 1 workflow), but I couldn't get a successful run without addressing these:
Before:
After:
