fix: update jest mock [DHIS2-15415] #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-314--dhis2-data-approval.netlify.app |
KaiVandivier
approved these changes
Aug 14, 2023
kabaros
approved these changes
Sep 13, 2023
|
🎉 This PR is included in version 100.0.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought (🤦♂️) I had fixed this issue with #276...
but unfortunately, I guessed incorrectly about how
moment.fromNow()works.I thought that if today were 8 August 2023 and the comparison date was 1 January 2021, that the relative date would be "two years ago", but it turns out moment.fromNow()` rounds up and returns "three years ago" in this case.
Which causes these tests to fail again, so, in order to work with what our test expects ("two years ago"), I've updated the moment mocking to return a date exactly two years previous to the current date, so that
moment(someDate).fromNow()should now return "two years ago".(sorry 😔)