refactor: use platform/runtime plugin components #2431
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
435147b
to
3091fdd
Compare
|
🚀 Deployed on https://pr-2431--dhis2-dashboard.netlify.app |
jenniferarnesen
force-pushed
the
dev
branch
from
e63aff9
to
35877e1
Compare
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
96c2efc
to
4edc634
Compare
jenniferarnesen
force-pushed
the
dev
branch
2 times, most recently
from
b919316
to
7f603d6
Compare
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
4edc634
to
35e3fc4
Compare
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
35e3fc4
to
75857e8
Compare
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
75857e8
to
abb9749
Compare
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
abb9749
to
2673f06
Compare
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
34809de
to
92cea63
Compare
| @@ -3,14 +3,17 @@ | |||
| exports[`ContentMenuItem has a LaunchLink when url is provided 1`] = ` | |||
| <div> | |||
| <li | |||
| class="jsx-1930534478 " | |||
| class="jsx-3192368000 " | |||
There was a problem hiding this comment.
Maybe this test needs to be changed so we don't get these diffs when the ui version is upgraded.
This silences warnings in the console.
Link is rendering an a tag, and MenuItem does the same. Use a redirect on click instead (already done in the print submenu)
This hopefully has a better solution.
It should be enough to just use isParentCached for knowing when to start recording and removing the cache in the plugins.
This should fix some issues with plugin content not being visible.
This is to avoid the error boundary to show up for uncaught errors (failed to fetch a visualization) which interferes with Cypress testing.
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
7e97897
to
5c40e73
Compare
…rm-plugin-components
This is needed as the new plugin system is used, because the messages used in the communication have changed.
…rm-plugin-components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DHIS2-17268
Relates to dhis2/data-visualizer-app#3082
Relates to dhis2/line-listing-app#396
Relates to dhis2/maps-app#3232
Key features
app-runtimeDescription
Generic components for plugins are available in
app-platformandapp-runtime.This PR is removing the original iframe plugin with the message handling that has been "moved" to the platform.
All analytics apps have a correspondent PR for using the platform plugin build with embedded message handling.
Cypress started to fail in >=41 because the login mechanism changed.
Dashboard is still using v6.9.1 of Cypress which prevents us from upgrading
cli-utils-cypressto a recent version with support for the new login.The temporary solution is to add a custom login command which accommodates login for all DHIS2 versions.
TODO
removeCachedDatamessage to the plugin without re-renderingrecordOnNextLoadto avoid multiple recordingsKnown issues
Screenshots