refactor: use shared dashboard plugin wrapper #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-396.line-listing.netlify.dhis2.org |
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
b365999
to
e156657
Compare
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
795334d
to
16060c2
Compare
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
16060c2
to
ea99422
Compare
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
dc5c207
to
af32223
Compare
edoardo
changed the title
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
af32223
to
3ed21de
Compare
edoardo
added
the
e2e record
|
Test summaryRun details
Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
5 tasks
This causes Cypress to fail due to the error overlay.
This should make some Cypress tests pass.
Waiting for a decision on how to treat the time dimensions.
edoardo
force-pushed
the
refactor/use-platform-plugin-components
branch
from
a53dde3
to
8633759
Compare
…rm-plugin-components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the fix for: DHIS2-17268
Requires dhis2/analytics#1672
Key features
Description
Generic components for plugins are available in
app-platformandapp-runtime.Analytics apps are currently having the same components replicated in each repo, a shared dashboard plugin wrapper has been added in
analytics.Known issues
Screenshots