[TechDebt: Issue #317] Deprecate multiregion resource name level #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature was introduced in early days of the provider to support multi-region. However, this model was not compatible with Terraform modules since the region was attached to the resource name. Later, multiregion support was added on the provider level as expected by Terraform enabling the provider to be used in modules and enabling users to specify the regions on the provider level. The multi-region support on the resource name level has been still supported till now but it's time to say goodbye to features that had some value in the past but now don't make sense and makes the code more difficult to read and maintain.
dikhan
changed the title
Codecov Report
@@ Coverage Diff @@
## master #316 +/- ##
==========================================
+ Coverage 93.34% 93.56% +0.22%
==========================================
Files 60 60
Lines 3651 3591 -60
==========================================
- Hits 3408 3360 -48
+ Misses 170 163 -7
+ Partials 73 68 -5
Continue to review full report at Codecov.
|
dikhan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this Pull Request solve?
Please link to the issue number here (issue will be closed when PR is merged): Closes #317
Type of change
What type of change does your code introduce to the provider? Please put an
x(w/o heading/trailing white spaces) in the boxes that apply:Checklist
Please put an
x(w/o heading/trailing white spaces) in the boxes that apply:make test-all[FeatureRequest: Issue #X] <PR Title>[BugFix: Issue #X] <PR Title>[TechDebt: Issue #X] <PR Title>[NewRelease] vX.Y.ZChecklist for Admins