Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewRelease] v3.0.0 #340

Merged
merged 1 commit into from
Apr 18, 2022
Merged

[NewRelease] v3.0.0 #340

merged 1 commit into from
Apr 18, 2022

Conversation

dikhan
Copy link
Owner

@dikhan dikhan commented Apr 18, 2022

What problem does this Pull Request solve?

This release v3.0.0 contains a number of upgrades as well as breaking changes that were due for deprecation and as part of being able to continue evolve the plugin along with the latest version of Terraform and eliminate tech debt reduction certain old functionality needed to be cleaned up. Summarizing below the breaking changes for the ref (this will be added in the release notes too):

  • Deprecation of multi-region support on resource name level: This feature was introduced in early days of the provider to support multi-region. However, this model was not compatible with Terraform modules since the region was attached to the resource name. Later, multi-region support was added on the provider level as expected by Terraform enabling
    the provider to be used in modules and enabling users to specify the regions on the provider level. The multi-region support on the resource name level has been still supported till now but it's time to say goodbye to features that had some value in the past but now don't make sense and makes the code more difficult to read and maintain.
  • Deprecate plugin_version property from OpenAPI config file SchemaV1: The OpenAPI Terraform config file enabled the user to specify the plugin_version as a way to ensure the config is targeted towards a specific version of the OpenAPI plugin binary. This was a feature added in early stages of the provider as a security mechanism to validate that the expected version of the binary was being used or fail close at runtime otherwise. This mechanism is no longer working as intended causing issues for users when they have different Terraform configurations each pointing at different versions of the OpenAPI Terraform provider but yet the global OpenAPI Terraform plugin configuration is set with one specific version.

Type of change

What type of change does your code introduce to the provider? Please put an x (w/o heading/trailing white spaces) in the boxes that apply:

  • New feature (change that adds new functionality)
  • Bug-fix (change that fixes current functionality)
  • Tech debt (enhances the current functionality)
  • New release (pumps the version)

Checklist

Please put an x (w/o heading/trailing white spaces) in the boxes that apply:

  • I have read and followed the CONTRIBUTING guidelines
  • I have added tests that prove my fix is effective or that my feature works
  • I have made sure code compiles correctly and all tests are passing by running make test-all
  • I have added/updated necessary documentation (if appropriate)
  • I have added the following info to the title of the PR (pick the appropriate option for the type of change). This is important because the release notes will include this information.
    • Feature Request: PRs related to feature requests should have in the title [FeatureRequest: Issue #X] <PR Title>
    • Bug Fixes: PRs related to bug fixes should have in the title [BugFix: Issue #X] <PR Title>
    • Tech Debt: PRs related to technical debt should have in the title [TechDebt: Issue #X] <PR Title>
    • New Release: PRs related to a new release should have in the title [NewRelease] vX.Y.Z

Checklist for Admins

  • Label is populated
  • PR is assigned to the corresponding project
  • PR has at least 1 reviewer and 1 assignee

@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #340 (8da9c46) into master (87f0897) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #340   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files          60       60           
  Lines        3584     3584           
=======================================
  Hits         3357     3357           
  Misses        160      160           
  Partials       67       67           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f0897...8da9c46. Read the comment docs.

@dikhan dikhan changed the title Release v3.0.0 [NewRelease] v3.0.0 Apr 18, 2022
@dikhan dikhan merged commit fdba646 into master Apr 18, 2022
@dikhan dikhan deleted the release-v3.0.0 branch April 18, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant