Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command Age-Restriction #973

Merged
merged 18 commits into from
Nov 18, 2022
Merged

Command Age-Restriction #973

merged 18 commits into from
Nov 18, 2022

Conversation

key2peace
Copy link
Collaborator

SQKo
SQKo requested changes Nov 11, 2022
View reviewed changes
Copy link
Member

@SQKo SQKo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also you have not added the fields yet to the create and update endpoints. Might good idea to wait the API docs PR status done from draft first.

src/Discord/Builders/CommandAttributes.php Outdated Show resolved Hide resolved
key2peace and others added 15 commits November 12, 2022 10:00
@key2peace @SQKo
Update src/Discord/Builders/CommandAttributes.php
e33b025 
Co-authored-by: SQKo <87897282+SQKo@users.noreply.github.com>
@key2peace
fix create/update
4d92469
@key2peace
Update Command.php
37077f4
@key2peace
Update Command.php
090df9d
@key2peace
getCreatableAttributes / getUpdatableAttributes
ee222bf
@key2peace
don't use property_exists
b633930
@key2peace
only check for key if fromObject is false
cd76f41
@key2peace
Revert "only check for key if fromObject is false"
8ba28d9 
This reverts commit cd76f41.
@key2peace
Revert "don't use property_exists"
36538cf 
This reverts commit b633930.
@key2peace
Revert "getCreatableAttributes / getUpdatableAttributes"
32e3730 
This reverts commit ee222bf.
@key2peace
use $this->getAttribute()
86bae73
@key2peace
Update Command.php
9ccab55
@key2peace
Update Command.php
be6f7d8
@key2peace
Merge pull request #977 from discord-php/master
caa70ce 
store buffer contents in string instead of array (#976)
@key2peace
fixes
652658c
@key2peace key2peace requested a review from SQKo November 13, 2022 03:24
@key2peace key2peace added the wait for discord Waiting for release by discord label Nov 13, 2022
@SQKo SQKo merged commit bb18f53 into master Nov 18, 2022
@SQKo SQKo removed the wait for discord Waiting for release by discord label Nov 18, 2022
@SQKo
Copy link
Member

SQKo commented Nov 18, 2022 •
edited
Loading

backport to:

  • v7

@key2peace key2peace deleted the key2peace-patch-2 branch November 27, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SQKo SQKo SQKo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@key2peace @SQKo