Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs about age-restricted commands #5617

Merged
merged 8 commits into from
Dec 13, 2022

Conversation

shaydewael
Copy link
Contributor

Will be merged on 11/16 with the release of new client updates, though apps can set the nsfw whenever

@shaydewael shaydewael added the not released This issue or PR is referencing a change that is not yet widely released and/or subject to change. label Nov 9, 2022
Copy link
Contributor

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume there'll be a changelog addition added later?

docs/interactions/Application_Commands.md Outdated Show resolved Hide resolved
docs/interactions/Application_Commands.md Outdated Show resolved Hide resolved
docs/interactions/Application_Commands.md Outdated Show resolved Hide resolved
docs/interactions/Application_Commands.md Outdated Show resolved Hide resolved
docs/interactions/Application_Commands.md Outdated Show resolved Hide resolved
shaydewael and others added 6 commits November 10, 2022 09:40
Co-authored-by: Lala Sabathil <aiko@aitsys.dev>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@shaydewael
Copy link
Contributor Author

@Jiralite yah will add a changelog day of or day before

@Lulalaby
Copy link
Contributor

Great! The rest looks good. Thanks again discord team ❤️

@shaydewael
Copy link
Contributor Author

shaydewael commented Nov 10, 2022

quick update:

  • right now, nsfw is only in response if it's set to true. this is how it was documented yesterday
  • but before this goes live, it will always appear in the response (similar to other fields), and will just resolve to false. I've updated the PR to be inline with the upcoming behavior, NOT the current behavior.

key2peace added a commit to discord-php/DiscordPHP that referenced this pull request Nov 11, 2022
SQKo added a commit to discord-php/DiscordPHP that referenced this pull request Nov 18, 2022
* Age restricted commands

(discord/discord-api-docs#5617)

* Command Age-Restriction

* Update src/Discord/Builders/CommandAttributes.php

Co-authored-by: SQKo <87897282+SQKo@users.noreply.github.com>

* fix create/update

* Update Command.php

* Update Command.php

* getCreatableAttributes / getUpdatableAttributes

* don't use property_exists

* only check for key if fromObject is false

* Revert "only check for key if fromObject is false"

This reverts commit cd76f41.

* Revert "don't use property_exists"

This reverts commit b633930.

* Revert "getCreatableAttributes / getUpdatableAttributes"

This reverts commit ee222bf.

* use $this->getAttribute()

* Update Command.php

* Update Command.php

* dot

Co-authored-by: SQKo <87897282+SQKo@users.noreply.github.com>
lukellmann added a commit to kordlib/kord that referenced this pull request Nov 18, 2022
The DSL looks like this:
val command = kord.createGlobalChatInputCommand(
    name = "restricted-command",
    description = "Only for users > 18",
) {
    nsfw = true
    dmPermission = true
}
println(command.nsfw)

see discord/discord-api-docs#5617
@TheUntraceable
Copy link
Contributor

When will this be merged?

@seailz
Copy link
Contributor

seailz commented Dec 3, 2022

@shaydewael Is this going to be merged?

@TheUntraceable
Copy link
Contributor

@shaydewael, it's been a month and no comment; what's to happen with this PR? Have you forgotten about it? Internal issues?

@shaydewael shaydewael marked this pull request as ready for review December 13, 2022 17:17
@shaydewael shaydewael merged commit cf06a70 into discord:main Dec 13, 2022
@shaydewael shaydewael deleted the add-age-restricted-docs branch December 13, 2022 17:18
lukellmann added a commit to kordlib/kord that referenced this pull request Jan 24, 2023
The DSL looks like this:
val command = kord.createGlobalChatInputCommand(
    name = "restricted-command",
    description = "Only for users > 18",
) {
    nsfw = true
    dmPermission = true
}
println(command.nsfw)

see discord/discord-api-docs#5617
lukellmann added a commit to kordlib/kord that referenced this pull request Jan 24, 2023
The DSL looks like this:
val command = kord.createGlobalChatInputCommand(
    name = "restricted-command",
    description = "Only for users > 18",
) {
    nsfw = true
    dmPermission = true
}
println(command.nsfw)

see discord/discord-api-docs#5617
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not released This issue or PR is referencing a change that is not yet widely released and/or subject to change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants