Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ServiceRepositoryTrait with missing ManagerRegistry param #782

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

mustanggb
Copy link
Contributor

@mustanggb mustanggb commented Oct 24, 2023

Using static analysis gives the error:

Expected type 'Doctrine\Persistence\ManagerRegistry'. Found 'Doctrine\ODM\MongoDB\DocumentManager'
@param \Doctrine\ODM\MongoDB\DocumentManager $registry

@mustanggb
Copy link
Contributor Author

Opened #783 for the unrelated Static Analysis failure.

@malarzm malarzm changed the base branch from 4.7.x to 4.6.x October 24, 2023 20:33
@malarzm malarzm added the Task label Oct 24, 2023
@malarzm malarzm added this to the 4.6.2 milestone Oct 24, 2023
@malarzm
Copy link
Member

malarzm commented Oct 24, 2023

@mustanggb thanks for the PR! I've taken care of the fail you've mentioned, thanks for pointing me to a dangling PR. That also made me realize that your PR was targeted at wrong branch, I've changed it to 4.6.x so we'll be able to release that as a bugfix sooner than later.

Would you mind:

  • rebsing your branch atop 4.6.x
  • squashing your commits
  • add a more meaningful commit message? PR's title is a good candidate :)

@malarzm malarzm linked an issue Oct 24, 2023 that may be closed by this pull request
@mustanggb mustanggb force-pushed the param-managerregistry branch 2 times, most recently from 7ce0b8a to 600c2fb Compare October 25, 2023 09:55
@mustanggb
Copy link
Contributor Author

mustanggb commented Oct 25, 2023

Would you mind:

  • rebsing your branch atop 4.6.x
  • squashing your commits
  • add a more meaningful commit message? PR's title is a good candidate :)

Done.

@malarzm malarzm merged commit 0a533e9 into doctrine:4.6.x Oct 25, 2023
30 checks passed
@malarzm
Copy link
Member

malarzm commented Oct 25, 2023

Thanks @mustanggb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registry constructor expected ManagerRegistry found DocumentManager
2 participants