Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TailCursorDoctrineODMCommand Static Analysis #783

Closed
wants to merge 1 commit into from
Closed

Fix TailCursorDoctrineODMCommand Static Analysis #783

wants to merge 1 commit into from

Conversation

mustanggb
Copy link
Contributor

@mustanggb mustanggb commented Oct 24, 2023 •
edited
Loading

Fix the following complaints from Static Analysis.

[InvalidNullableReturnType: Command/TailCursorDoctrineODMCommand.php#L111](https://github.com/mustanggb/DoctrineMongoDBBundle/commit/294b0fb99432bd5a21dbcc24f87f195bcb2cf7b8#annotation_15142273754)
Command/TailCursorDoctrineODMCommand.php:111:17: InvalidNullableReturnType: The declared return type 'Psr\Container\ContainerInterface' for Doctrine\Bundle\MongoDBBundle\Command\TailCursorDoctrineODMCommand::getContainer is not nullable, but 'Symfony\Component\DependencyInjection\ContainerInterface|null' contains null (see https://psalm.dev/144)

[NullableReturnStatement: Command/TailCursorDoctrineODMCommand.php#L114](https://github.com/mustanggb/DoctrineMongoDBBundle/commit/294b0fb99432bd5a21dbcc24f87f195bcb2cf7b8#annotation_15142273760)
Command/TailCursorDoctrineODMCommand.php:114:16: NullableReturnStatement: The declared return type 'Psr\Container\ContainerInterface' for Doctrine\Bundle\MongoDBBundle\Command\TailCursorDoctrineODMCommand::getContainer is not nullable, but the function returns 'Symfony\Component\DependencyInjection\ContainerInterface|null' (see https://psalm.dev/139)

@mustanggb mustanggb mentioned this pull request Oct 24, 2023
Merged
@mustanggb
Copy link
Contributor Author

Duplicate of #780.

@mustanggb mustanggb closed this Oct 24, 2023
@mustanggb mustanggb deleted the static-analysis branch October 25, 2023 10:22
@GromNaN GromNaN added this to the 4.7.0 milestone Dec 22, 2023
@github-actions github-actions bot mentioned this pull request Dec 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mustanggb @GromNaN