TypeRegistry constructor must check for duplicate instances #6083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
force-pushed
the
check_dupl_instance_type_registry
branch
2 times, most recently
from
0d942e6
to
d3d11b4
Compare
mvorisek
changed the title
derrabus
requested changes
Jul 8, 2023
mvorisek
force-pushed
the
check_dupl_instance_type_registry
branch
from
8aebad3
to
ba67b42
Compare
|
Landed thru #6082. |
derrabus
pushed a commit
that referenced
this pull request
Jul 15, 2023
| Q | A |------------- | ----------- | Type | performance issue | Fixed issues | n/a #### Summary We use a lot of custom types and migration from `Type::getName()` to `TypeRegistry->lookupName()` discovered us the reverse lookup was very slow (O(N)). This PR makes it O(1). ~Index is initialized lazily on the 1st reverse lookup.~ The type registry is expected to not hold duplicate type instances and this PR fixes it, in #6083 (comment) I was requested to fix it in this PR instead of a separate one.
cgknx
pushed a commit
to cgknx/dbal
that referenced
this pull request
Aug 30, 2023
| Q | A |------------- | ----------- | Type | performance issue | Fixed issues | n/a #### Summary We use a lot of custom types and migration from `Type::getName()` to `TypeRegistry->lookupName()` discovered us the reverse lookup was very slow (O(N)). This PR makes it O(1). ~Index is initialized lazily on the 1st reverse lookup.~ The type registry is expected to not hold duplicate type instances and this PR fixes it, in doctrine#6083 (comment) I was requested to fix it in this PR instead of a separate one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
a)
TypeRegistrymethods likeTypeRegistry::registerchecks if the type instance is not already registered.b)
TypeRegistry::lookupNamemethod expects the instance to have only one name.Thus I belive the type registry is expected to not hold duplicate type instances and this PR fixes/asserts that.
Also documented so - https://github.com/doctrine/dbal/blob/3.6.4/src/Types/TypeRegistry.php#L14