This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add symbol publish (index/archive) build leg #11300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
reviewed
Apr 28, 2017
| "value": "false", | ||
| "allowOverride": true | ||
| }, | ||
| "PB_ConfigurationGroup": { |
There was a problem hiding this comment.
ConfigurationGroup is a CoreFXism, can you change this to PB_BuildType?
There was a problem hiding this comment.
Sure. Would be nice if this converged, though.
wtgodbe
approved these changes
Apr 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new publish build leg that publishes symbols using VSTS Symbol and, when building a release branch, archives them on the official Msft public symbol server. See dotnet/corefx#18350.
This also deletes some outdated symbol publishing/indexing steps that were already disabled in the Windows legs.
I tested this out by creating a live def based on
DotNet-Trusted-Publish-Symbols.jsonand running it against existing build drops.Resolves https://github.com/dotnet/core-eng/issues/540, https://github.com/dotnet/coreclr/issues/7824, and https://github.com/dotnet/coreclr/issues/10809
Todo: https://github.com/dotnet/core-eng/issues/703 (port this to release/2.0.0)