This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Add separate symbol publish (index/archive) build leg #18350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused variable PB_SymbolsBuildIdRoot
dagood
force-pushed
the
symbol-publish-leg
branch
from
cfc4a6c
to
e014250
Compare
|
@dagood still in progress? |
|
@danmosemsft Yes, waiting for review. |
weshaggard
approved these changes
Apr 25, 2017
Agreed. There is a new VSTS feature for conditions on steps that would let us stop doing that (without extra buildtools work), but our toolchain doesn't support it yet. |
This was referenced Apr 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #16939.
This switches indexing to use VSTS Symbol. It handles hosting, so the builds don't need to copy to a file share. For release branch builds, archiving performance (still using the file share) is improved by dotnet/buildtools#1421.
The time this leg's steps take for a daily/indexed build is now:
I removed the symbol publishing steps from the Windows build legs because they're redundant. Removing the publish target path from the index+publish step means it will only index sources for the symbols and won't copy them anywhere. (Edit: on a test build I see that this step is only finding 2 PDBs, and it isn't able to find sources for them. Getting symbol indexing working properly is tracked by https://github.com/dotnet/core-eng/issues/499.)