This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Update BuildTools, CoreClr to preview4-04022-01, preview6-27721-71, respectively (master) #24369

Merged

stephentoub merged 4 commits into dotnet:master from dotnet-maestro-bot:master-UpdateDependencies

May 24, 2019

dotnet-maestro-bot commented May 3, 2019

/cc @dotnet/maestro-reviewers-core

Author

dotnet-maestro-bot commented May 3, 2019

Discarded 3627048: Update CoreClr to preview6-27702-72

CI Status: 8:heavy_check_mark: (click to expand)

✔️ license/cla All CLA requirements met. Details
✔️ Ubuntu arm Cross Checked crossgen_comparison Build and Test Build finished. Details
✔️ Ubuntu arm Cross Release crossgen_comparison Build and Test Build finished. Details
✔️ Ubuntu x64 Checked CoreFX Tests Build finished. Details
✔️ Ubuntu x64 Formatting Build finished. Details
✔️ Windows_NT x64 Checked CoreFX Tests Build finished. Details
✔️ Windows_NT x64 Formatting Build finished. Details
✔️ Windows_NT x64 Release CoreFX Tests Build finished. Details

dotnet-maestro-bot changed the title ~~Update CoreClr to preview6-27702-72 (master)~~ Update CoreClr to preview6-27703-71 (master)

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 3627048 to bd11fcd Compare

May 3, 2019 13:06

Member

wtgodbe commented May 3, 2019

/azp run

azure-pipelines bot commented May 3, 2019

Azure Pipelines successfully started running 2 pipeline(s).

Author

dotnet-maestro-bot commented May 4, 2019

Discarded bd11fcd: Update CoreClr to preview6-27703-71

CI Status: 8:heavy_check_mark: (click to expand)

✔️ license/cla All CLA requirements met. Details
✔️ Ubuntu arm Cross Checked crossgen_comparison Build and Test Build finished. Details
✔️ Ubuntu arm Cross Release crossgen_comparison Build and Test Build finished. Details
✔️ Ubuntu x64 Checked CoreFX Tests Build finished. Details
✔️ Ubuntu x64 Formatting Build finished. Details
✔️ Windows_NT x64 Checked CoreFX Tests Build finished. Details
✔️ Windows_NT x64 Formatting Build finished. Details
✔️ Windows_NT x64 Release CoreFX Tests Build finished. Details

dotnet-maestro-bot changed the title ~~Update CoreClr to preview6-27703-71 (master)~~ Update CoreClr to preview6-27704-71 (master)

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from bd11fcd to 1ed92c1 Compare

May 4, 2019 13:09

Author

dotnet-maestro-bot commented May 4, 2019

Discarded 1ed92c1: Update CoreClr to preview6-27704-71

CI Status: 1:heavy_check_mark: (click to expand)

✔️ license/cla All CLA requirements met. Details

dotnet-maestro-bot changed the title ~~Update CoreClr to preview6-27704-71 (master)~~ Update BuildTools, CoreClr to preview4-04004-01, preview6-27704-71, respectively (master)

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 1ed92c1 to 8683825 Compare

May 4, 2019 22:58

Author

dotnet-maestro-bot commented May 5, 2019

Discarded 8683825: Update BuildTools, CoreClr to preview4-04004-01, preview6-27704-71, respectively

CI Status: 1:heavy_check_mark: (click to expand)

✔️ license/cla All CLA requirements met. Details

dotnet-maestro-bot changed the title ~~Update BuildTools, CoreClr to preview4-04004-01, preview6-27704-71, respectively (master)~~ Update BuildTools, CoreClr to preview4-04004-01, preview6-27704-72, respectively (master)

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 8683825 to c3d265b Compare

May 5, 2019 01:37

Author

dotnet-maestro-bot commented May 5, 2019

Discarded c3d265b: Update BuildTools, CoreClr to preview4-04004-01, preview6-27704-72, respectively

CI Status: 1:heavy_check_mark: (click to expand)

✔️ license/cla All CLA requirements met. Details

dotnet-maestro-bot changed the title ~~Update BuildTools, CoreClr to preview4-04004-01, preview6-27704-72, respectively (master)~~ Update BuildTools, CoreClr to preview4-04004-01, preview6-27705-71, respectively (master)

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from c3d265b to 8580fb8 Compare

May 5, 2019 13:01

Author

dotnet-maestro-bot commented May 6, 2019

Discarded 8580fb8: Update BuildTools, CoreClr to preview4-04004-01, preview6-27705-71, respectively

CI Status: 1:heavy_check_mark: (click to expand)

✔️ license/cla All CLA requirements met. Details

dotnet-maestro-bot changed the title ~~Update BuildTools, CoreClr to preview4-04004-01, preview6-27705-71, respectively (master)~~ Update BuildTools, CoreClr to preview4-04004-01, preview6-27705-72, respectively (master)

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 8580fb8 to 2abd1cf Compare

May 6, 2019 01:19

Author

dotnet-maestro-bot commented May 6, 2019

Discarded 2abd1cf: Update BuildTools, CoreClr to preview4-04004-01, preview6-27705-72, respectively

CI Status: 1:heavy_check_mark: (click to expand)

✔️ license/cla All CLA requirements met. Details

dotnet-maestro-bot changed the title ~~Update BuildTools, CoreClr to preview4-04004-01, preview6-27705-72, respectively (master)~~ Update BuildTools, CoreClr to preview4-04004-01, preview6-27706-71, respectively (master)

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 2abd1cf to f6fe833 Compare

May 6, 2019 13:10

Author

dotnet-maestro-bot commented May 7, 2019

Discarded f6fe833: Update BuildTools, CoreClr to preview4-04004-01, preview6-27706-71, respectively

CI Status: 1:heavy_check_mark: (click to expand)

✔️ license/cla All CLA requirements met. Details

dotnet-maestro-bot changed the title ~~Update BuildTools, CoreClr to preview4-04004-01, preview6-27706-71, respectively (master)~~ Update BuildTools, CoreClr to preview4-04004-01, preview6-27706-72, respectively (master)

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from f6fe833 to dc32215 Compare

May 7, 2019 01:02

Author

dotnet-maestro-bot commented May 7, 2019

Discarded dc32215: Update BuildTools, CoreClr to preview4-04004-01, preview6-27706-72, respectively

CI Status: 1:heavy_check_mark: (click to expand)

✔️ license/cla All CLA requirements met. Details

dotnet-maestro-bot changed the title ~~Update BuildTools, CoreClr to preview4-04004-01, preview6-27706-72, respectively (master)~~ Update BuildTools, CoreClr to preview4-04004-01, preview6-27707-71, respectively (master)

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from dc32215 to e3ec618 Compare

May 7, 2019 13:18

Author

dotnet-maestro-bot commented May 8, 2019

Discarded e3ec618: Update BuildTools, CoreClr to preview4-04004-01, preview6-27707-71, respectively

CI Status: 1:heavy_check_mark: (click to expand)

✔️ license/cla All CLA requirements met. Details

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 15a7d48 to afafe47 Compare

May 21, 2019 01:16

Author

dotnet-maestro-bot commented May 21, 2019

Discarded afafe47: Update BuildTools, CoreClr to preview4-04015-01, preview6-27720-72, respectively

CI Status: 1:heavy_check_mark: (click to expand)

✔️ license/cla All CLA requirements met. Details

dotnet-maestro-bot changed the title ~~Update BuildTools, CoreClr to preview4-04015-01, preview6-27720-72, respectively (master)~~ Update BuildTools, CoreClr to preview4-04021-02, preview6-27720-72, respectively (master)

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from afafe47 to b3ac707 Compare

May 21, 2019 04:47

Author

dotnet-maestro-bot commented May 21, 2019

Discarded b3ac707: Update BuildTools, CoreClr to preview4-04021-02, preview6-27720-72, respectively

CI Status: 1:heavy_check_mark: (click to expand)

✔️ license/cla All CLA requirements met. Details

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from b3ac707 to 0f00bfb Compare

May 21, 2019 14:16

dotnet-maestro-bot changed the title ~~Update BuildTools, CoreClr to preview4-04021-02, preview6-27720-72, respectively (master)~~ Update BuildTools, CoreClr to preview4-04021-02, preview6-27721-71, respectively (master)

Author

dotnet-maestro-bot commented May 22, 2019

Discarded 0f00bfb: Update BuildTools, CoreClr to preview4-04021-02, preview6-27721-71, respectively

CI Status: 1:heavy_check_mark: (click to expand)

✔️ license/cla All CLA requirements met. Details


          Update BuildTools, CoreClr to preview4-04022-01, preview6-27721-71, r…

deb2851

…espectively

dotnet-maestro-bot changed the title ~~Update BuildTools, CoreClr to preview4-04021-02, preview6-27721-71, respectively (master)~~ Update BuildTools, CoreClr to preview4-04022-01, preview6-27721-71, respectively (master)

dotnet-maestro-bot force-pushed the master-UpdateDependencies branch from 0f00bfb to deb2851 Compare

May 22, 2019 21:06

Member

tannergooding commented May 22, 2019

CC. @dotnet/nullablefc. Lots of failures around error CS8632: The annotation for nullable reference types should only be used in code within a '#nullable' context..

Member

stephentoub commented May 22, 2019

I can take a look tonight.


          Use Nullable=enable rather than NullableContextOptions=enable

b8076eb

Member

tannergooding commented May 22, 2019

Failures were because NullableContextOptions=enable was changed to be Nullable=enable. I've pushed a commit resolving that.

Member

safern commented May 22, 2019

You beat me. I was about to comment that. Thanks, @tannergooding

Member

tannergooding commented May 22, 2019

Remaining failures are:

shared\System\Threading\ThreadPool.cs(914,77): error CS8622: Nullability of reference types in type of parameter 'state' of 'void _ThreadPoolWaitOrTimerCallback.WaitOrTimerCallback_Context_t(object state)' doesn't match the target delegate 'ContextCallback'. [D:\repos\coreclr\src\System.Private.CoreLib\System.Private.CoreLib.csproj]

shared\System\Threading\ThreadPool.cs(915,77): error CS8622: Nullability of reference types in type of parameter 'state' of 'void _ThreadPoolWaitOrTimerCallback.WaitOrTimerCallback_Context_f(object state)' doesn't match the target delegate 'ContextCallback'. [D:\repos\coreclr\src\System.Private.CoreLib\System.Private.CoreLib.csproj]

src\System\Threading\Overlapped.cs(45,68): error CS8622: Nullability of reference types in type of parameter 'state' of 'void _IOCompletionCallback.IOCompletionCallback_Context(object state)' doesn't match the target delegate 'ContextCallback'. [D:\repos\coreclr\src\System.Private.CoreLib\System.Private.CoreLib.csproj]

src\System\Threading\Tasks\AsyncCausalityTracer.cs(72,141): error CS8622: Nullability of reference types in type of parameter 'sender' of 'void AsyncCausalityTracer.TracingStatusChangedHandler(object sender, TracingStatusChangedEventArgs args)' doesn't match the target delegate 'EventHandler<TracingStatusChangedEventArgs>'. [D:\repos\coreclr\src\System.Private.CoreLib\System.Private.CoreLib.csproj]

shared\System\Threading\Tasks\FutureFactory.cs(663,36): error CS8604: Possible null reference argument for parameter 'iar' in 'void TaskFactory<TResult>.FromAsyncCoreLogic(IAsyncResult iar, Func<IAsyncResult, TResult>? endFunction, Action<IAsyncResult>? endAction, Task<TResult> promise, bool requiresSynchronization)'. [D:\repos\coreclr\src\System.Private.CoreLib\System.Private.CoreLib.csproj]

shared\System\Progress.cs(37,54): error CS8622: Nullability of reference types in type of parameter 'state' of 'void Progress<T>.InvokeHandlers(object state)' doesn't match the target delegate 'SendOrPostCallback'. [D:\repos\coreclr\src\System.Private.CoreLib\System.Private.CoreLib.csproj]


          Resolving new nullability warnings

dc4e33e

Member

tannergooding commented May 22, 2019

Pushed a commit to resolve the new nullability warnings. One was just another case that will be resolved by DoesNotReturn. The others are new and due to nullability analysis trying to match a delegate signatures with the given method signature. I logged dotnet/roslyn#35896 for the case where it warns when you have a non-nullable method signature parameter matched against a nullable delegate signature parameter.

Member

tannergooding commented May 22, 2019

dotnet/roslyn#35896 was closed as "by design" since you could invoke the delegate (which has a nullable parameter) and pass in a null and which would then invoke the method with the same null.

We'll need to decide if we want the method signatures to stay non-nullable (and therefore need to keep the !) or if we want to change them to be nullable instead.

stephentoub reviewed

View reviewed changes

src/System.Private.CoreLib/shared/System/Progress.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/System.Private.CoreLib/shared/System/Threading/ThreadPool.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/System.Private.CoreLib/src/System/Threading/Overlapped.cs Outdated Show resolved Hide resolved

stephentoub reviewed

View reviewed changes

src/System.Private.CoreLib/src/System/Threading/Tasks/AsyncCausalityTracer.cs Outdated Show resolved Hide resolved

Member

tannergooding commented May 23, 2019

@dotnet/nullablefc, could someone else finish resolving the feedback above. I am OOF sick today.

Member

safern commented May 23, 2019

I’ll finish it after lunch.


          PR Feedback

c9a71eb

stephentoub approved these changes

View reviewed changes

Member

stephentoub left a comment

Thanks, guys.

stephentoub merged commit b2b7cab into dotnet:master

picenka21 pushed a commit to picenka21/runtime that referenced this pull request


          Update BuildTools, CoreClr to preview4-04022-01, preview6-27721-71, r…

ed33ce4

…espectively (master) (dotnet/coreclr#24369)

* Update BuildTools, CoreClr to preview4-04022-01, preview6-27721-71, respectively

* Use `Nullable=enable` rather than `NullableContextOptions=enable`

* Resolving new nullability warnings

* PR Feedback


Commit migrated from dotnet/coreclr@b2b7cab

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet