Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.

Update BuildTools, CoreClr to preview4-04022-01, preview6-27721-71, respectively (master) #24369

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion BuildToolsVersion.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0.0-preview4-03930-01
3.0.0-preview4-04022-01
2 changes: 1 addition & 1 deletion ILAsmVersion.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.0.0-preview6-27702-71
3.0.0-preview6-27721-71
6 changes: 3 additions & 3 deletions dependencies.props
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@

<!-- Source of truth for dependency tooling: the commit hash of the dotnet/versions master branch as of the last auto-upgrade. -->
<PropertyGroup>
<CoreClrCurrentRef>f1ee12b0dab462d0f58b87e878250146a125d9ff</CoreClrCurrentRef>
<BuildToolsCurrentRef>9519ad281b838b0b2bffa86b2837994d4f7c41d3</BuildToolsCurrentRef>
<CoreClrCurrentRef>00797464e62272e9c721a1854abe49ff05743bdf</CoreClrCurrentRef>
<BuildToolsCurrentRef>00797464e62272e9c721a1854abe49ff05743bdf</BuildToolsCurrentRef>
</PropertyGroup>

<!-- Tests/infrastructure dependency versions. -->
<PropertyGroup>
<MicrosoftNETCoreRuntimeCoreCLRPackageVersion>3.0.0-preview6-27702-71</MicrosoftNETCoreRuntimeCoreCLRPackageVersion>
<MicrosoftNETCoreRuntimeCoreCLRPackageVersion>3.0.0-preview6-27721-71</MicrosoftNETCoreRuntimeCoreCLRPackageVersion>
<XunitPackageVersion>2.4.1-pre.build.4059</XunitPackageVersion>
<XunitPerformanceApiPackageVersion>1.0.0-beta-build0015</XunitPerformanceApiPackageVersion>
<MicrosoftDiagnosticsTracingTraceEventPackageVersion>2.0.40</MicrosoftDiagnosticsTracingTraceEventPackageVersion>
Expand Down
2 changes: 1 addition & 1 deletion src/System.Private.CoreLib/System.Private.CoreLib.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<!-- Remove CS8608 once https://github.com/dotnet/roslyn/issues/23268 is resolved -->
<NoWarn>649,1573,1591,0419,3021,CS8609</NoWarn>
<NullableContextOptions>enable</NullableContextOptions>
<Nullable>enable</Nullable>

<!-- Ignore all previous constants since SPCL is sensitive to what is defined and the Sdk adds some by default -->
<DefineConstants>CORECLR;netcoreapp</DefineConstants>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
<Import_RootNamespace />
</PropertyGroup>
<PropertyGroup>
<NullableContextOptions>enable</NullableContextOptions>
<Nullable>enable</Nullable>
</PropertyGroup>
<PropertyGroup>
<TargetsWindows Condition="'$(TargetsWindows)' != 'true'">false</TargetsWindows>
Expand Down
4 changes: 2 additions & 2 deletions src/System.Private.CoreLib/shared/System/Progress.cs
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,9 @@ protected virtual void OnReport(T value)

/// <summary>Invokes the action and event callbacks.</summary>
/// <param name="state">The progress value.</param>
private void InvokeHandlers(object state)
private void InvokeHandlers(object? state)
{
T value = (T)state;
T value = (T)state!;

Action<T>? handler = _handler;
EventHandler<T> changedEvent = ProgressChanged;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ internal static Task<TResult> FromAsyncImpl(
// RespectParentCancellation.
Task t = new Task(new Action<object>(delegate
{
FromAsyncCoreLogic(asyncResult, endFunction, endAction, promise, requiresSynchronization: true);
FromAsyncCoreLogic(asyncResult!, endFunction, endAction, promise, requiresSynchronization: true); // TODO-NULLABLE: https://github.com/dotnet/csharplang/issues/538
}),
(object?)null, null,
default, TaskCreationOptions.None, InternalTaskOptions.None, null);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -926,15 +926,15 @@ internal _ThreadPoolWaitOrTimerCallback(WaitOrTimerCallback waitOrTimerCallback,
}
}

private static void WaitOrTimerCallback_Context_t(object state) =>
private static void WaitOrTimerCallback_Context_t(object? state) =>
WaitOrTimerCallback_Context(state, timedOut: true);

private static void WaitOrTimerCallback_Context_f(object state) =>
private static void WaitOrTimerCallback_Context_f(object? state) =>
WaitOrTimerCallback_Context(state, timedOut: false);

private static void WaitOrTimerCallback_Context(object state, bool timedOut)
private static void WaitOrTimerCallback_Context(object? state, bool timedOut)
{
_ThreadPoolWaitOrTimerCallback helper = (_ThreadPoolWaitOrTimerCallback)state;
_ThreadPoolWaitOrTimerCallback helper = (_ThreadPoolWaitOrTimerCallback)state!;
helper._waitOrTimerCallback(helper._state, timedOut);
}

Expand Down
4 changes: 2 additions & 2 deletions src/System.Private.CoreLib/src/System/Threading/Overlapped.cs
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ internal _IOCompletionCallback(IOCompletionCallback ioCompletionCallback, Execut
}
// Context callback: same sig for SendOrPostCallback and ContextCallback
internal static ContextCallback _ccb = new ContextCallback(IOCompletionCallback_Context);
internal static void IOCompletionCallback_Context(object state)
internal static void IOCompletionCallback_Context(object? state)
{
_IOCompletionCallback helper = (_IOCompletionCallback)state;
_IOCompletionCallback? helper = (_IOCompletionCallback?)state;
Debug.Assert(helper != null, "_IOCompletionCallback cannot be null");
helper._ioCompletionCallback(helper._errorCode, helper._numBytes, helper._pNativeOverlapped);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ static AsyncCausalityTracer()
}
}

private static void TracingStatusChangedHandler(object sender, WFD.TracingStatusChangedEventArgs args)
private static void TracingStatusChangedHandler(object? sender, WFD.TracingStatusChangedEventArgs args)
{
if (args.Enabled)
f_LoggingOn |= Loggers.CausalityTracer;
Expand Down