Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChangePrefixNegationToInfixSubtraction code fixeroo #10471

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

cartermp
Copy link
Contributor

This one should help people who get tripped up on code like this:

image

I noticed this in a user study; it affected 2/10 people who mistyped the -1 when looping.

Just to reiterate: this only triggers on the "value is not a function and cannot be applied" error, and only suggests when the value being mistakenly applied starts with -, which is highly likely to be a mistyped - .

@cartermp
Copy link
Contributor Author

This is ready for review

@cartermp cartermp merged commit d1ebe37 into dotnet:main Nov 17, 2020
@cartermp cartermp deleted the change-prefix-to-infix-neg branch November 17, 2020 00:21
@cartermp cartermp added this to the 16.9 milestone Nov 17, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants