Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ChangePrefixNegationToInfixSubtraction code fixeroo #10471

Merged
merged 1 commit into from
Nov 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
// Copyright (c) Microsoft Corporation. All Rights Reserved. See License.txt in the project root for license information.

namespace Microsoft.VisualStudio.FSharp.Editor

open System
open System.Composition
open System.Threading.Tasks

open Microsoft.CodeAnalysis.Text
open Microsoft.CodeAnalysis.CodeFixes

[<ExportCodeFixProvider(FSharpConstants.FSharpLanguageName, Name = "ChangePrefixNegationToInfixSubtraction"); Shared>]
type internal FSharpChangePrefixNegationToInfixSubtractionodeFixProvider() =
inherit CodeFixProvider()

let fixableDiagnosticIds = set ["FS0003"]

override _.FixableDiagnosticIds = Seq.toImmutableArray fixableDiagnosticIds

override _.RegisterCodeFixesAsync context : Task =
asyncMaybe {
let diagnostics =
context.Diagnostics
|> Seq.filter (fun x -> fixableDiagnosticIds |> Set.contains x.Id)
|> Seq.toImmutableArray

let! sourceText = context.Document.GetTextAsync(context.CancellationToken)

let mutable pos = context.Span.End + 1

// This won't ever actually happen, but eh why not
do! Option.guard (pos < sourceText.Length)

let mutable ch = sourceText.GetSubText(TextSpan(pos, 1)).ToString().[0]

while pos < sourceText.Length && Char.IsWhiteSpace(ch) do
pos <- pos + 1
let text = sourceText.GetSubText(TextSpan(pos, 1))
ch <- text.ToString().[0]

// Bail if this isn't a negation
do! Option.guard (ch = '-')

let title = SR.ChangePrefixNegationToInfixSubtraction()

let codeFix =
CodeFixHelpers.createTextChangeCodeFix(
title,
context,
(fun () -> asyncMaybe.Return [| TextChange(TextSpan(pos, 1), "- ") |]))

context.RegisterCodeFix(codeFix, diagnostics)
}
|> Async.Ignore
|> RoslynHelpers.StartAsyncUnitAsTask(context.CancellationToken)
1 change: 1 addition & 0 deletions vsintegration/src/FSharp.Editor/FSharp.Editor.fsproj
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@
<Compile Include="Commands\FsiCommandService.fs" />
<Compile Include="Commands\XmlDocCommandService.fs" />
<Compile Include="CodeFix\CodeFixHelpers.fs" />
<Compile Include="CodeFix\ChangePrefixNegationToInfixSubtraction.fs" />
<Compile Include="CodeFix\AddNewKeywordToDisposableConstructorInvocation.fs" />
<Compile Include="CodeFix\AddOpenCodeFixProvider.fs" />
<Compile Include="CodeFix\ProposeUppercaseLabel.fs" />
Expand Down
3 changes: 3 additions & 0 deletions vsintegration/src/FSharp.Editor/FSharp.Editor.resx
Original file line number Diff line number Diff line change
Expand Up @@ -219,4 +219,7 @@
<data name="FSharpDisposableTopLevelValuesClassificationType" xml:space="preserve">
<value>F# Dispostable Values (top-level)</value>
</data>
<data name="ChangePrefixNegationToInfixSubtraction" xml:space="preserve">
<value>Use subtraction instead of negation</value>
</data>
</root>
5 changes: 5 additions & 0 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.cs.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="translated">Přidejte klíčové slovo new.</target>
<note />
</trans-unit>
<trans-unit id="ChangePrefixNegationToInfixSubtraction">
<source>Use subtraction instead of negation</source>
<target state="new">Use subtraction instead of negation</target>
<note />
</trans-unit>
<trans-unit id="FSharpDisposableLocalValuesClassificationType">
<source>F# Disposable Values (locals)</source>
<target state="new">F# Disposable Values (locals)</target>
Expand Down
5 changes: 5 additions & 0 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.de.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="translated">Schlüsselwort "new" hinzufügen</target>
<note />
</trans-unit>
<trans-unit id="ChangePrefixNegationToInfixSubtraction">
<source>Use subtraction instead of negation</source>
<target state="new">Use subtraction instead of negation</target>
<note />
</trans-unit>
<trans-unit id="FSharpDisposableLocalValuesClassificationType">
<source>F# Disposable Values (locals)</source>
<target state="new">F# Disposable Values (locals)</target>
Expand Down
5 changes: 5 additions & 0 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.es.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="translated">Agregar "nueva" palabra clave</target>
<note />
</trans-unit>
<trans-unit id="ChangePrefixNegationToInfixSubtraction">
<source>Use subtraction instead of negation</source>
<target state="new">Use subtraction instead of negation</target>
<note />
</trans-unit>
<trans-unit id="FSharpDisposableLocalValuesClassificationType">
<source>F# Disposable Values (locals)</source>
<target state="new">F# Disposable Values (locals)</target>
Expand Down
5 changes: 5 additions & 0 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.fr.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="translated">Ajouter le mot clé 'new'</target>
<note />
</trans-unit>
<trans-unit id="ChangePrefixNegationToInfixSubtraction">
<source>Use subtraction instead of negation</source>
<target state="new">Use subtraction instead of negation</target>
<note />
</trans-unit>
<trans-unit id="FSharpDisposableLocalValuesClassificationType">
<source>F# Disposable Values (locals)</source>
<target state="new">F# Disposable Values (locals)</target>
Expand Down
5 changes: 5 additions & 0 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.it.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="translated">Aggiungi la parola chiave 'new'</target>
<note />
</trans-unit>
<trans-unit id="ChangePrefixNegationToInfixSubtraction">
<source>Use subtraction instead of negation</source>
<target state="new">Use subtraction instead of negation</target>
<note />
</trans-unit>
<trans-unit id="FSharpDisposableLocalValuesClassificationType">
<source>F# Disposable Values (locals)</source>
<target state="new">F# Disposable Values (locals)</target>
Expand Down
5 changes: 5 additions & 0 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.ja.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="translated">'new' キーワードを追加する</target>
<note />
</trans-unit>
<trans-unit id="ChangePrefixNegationToInfixSubtraction">
<source>Use subtraction instead of negation</source>
<target state="new">Use subtraction instead of negation</target>
<note />
</trans-unit>
<trans-unit id="FSharpDisposableLocalValuesClassificationType">
<source>F# Disposable Values (locals)</source>
<target state="new">F# Disposable Values (locals)</target>
Expand Down
5 changes: 5 additions & 0 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.ko.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="translated">'new' 키워드 추가</target>
<note />
</trans-unit>
<trans-unit id="ChangePrefixNegationToInfixSubtraction">
<source>Use subtraction instead of negation</source>
<target state="new">Use subtraction instead of negation</target>
<note />
</trans-unit>
<trans-unit id="FSharpDisposableLocalValuesClassificationType">
<source>F# Disposable Values (locals)</source>
<target state="new">F# Disposable Values (locals)</target>
Expand Down
5 changes: 5 additions & 0 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.pl.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="translated">Dodaj słowo kluczowe „new”</target>
<note />
</trans-unit>
<trans-unit id="ChangePrefixNegationToInfixSubtraction">
<source>Use subtraction instead of negation</source>
<target state="new">Use subtraction instead of negation</target>
<note />
</trans-unit>
<trans-unit id="FSharpDisposableLocalValuesClassificationType">
<source>F# Disposable Values (locals)</source>
<target state="new">F# Disposable Values (locals)</target>
Expand Down
5 changes: 5 additions & 0 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.pt-BR.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="translated">Adicionar a palavra-chave 'new'</target>
<note />
</trans-unit>
<trans-unit id="ChangePrefixNegationToInfixSubtraction">
<source>Use subtraction instead of negation</source>
<target state="new">Use subtraction instead of negation</target>
<note />
</trans-unit>
<trans-unit id="FSharpDisposableLocalValuesClassificationType">
<source>F# Disposable Values (locals)</source>
<target state="new">F# Disposable Values (locals)</target>
Expand Down
5 changes: 5 additions & 0 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.ru.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="translated">Добавить ключевое слово "new"</target>
<note />
</trans-unit>
<trans-unit id="ChangePrefixNegationToInfixSubtraction">
<source>Use subtraction instead of negation</source>
<target state="new">Use subtraction instead of negation</target>
<note />
</trans-unit>
<trans-unit id="FSharpDisposableLocalValuesClassificationType">
<source>F# Disposable Values (locals)</source>
<target state="new">F# Disposable Values (locals)</target>
Expand Down
5 changes: 5 additions & 0 deletions vsintegration/src/FSharp.Editor/xlf/FSharp.Editor.tr.xlf
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="translated">'new' anahtar sözcüğünü ekleme</target>
<note />
</trans-unit>
<trans-unit id="ChangePrefixNegationToInfixSubtraction">
<source>Use subtraction instead of negation</source>
<target state="new">Use subtraction instead of negation</target>
<note />
</trans-unit>
<trans-unit id="FSharpDisposableLocalValuesClassificationType">
<source>F# Disposable Values (locals)</source>
<target state="new">F# Disposable Values (locals)</target>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="translated">添加“新”关键字</target>
<note />
</trans-unit>
<trans-unit id="ChangePrefixNegationToInfixSubtraction">
<source>Use subtraction instead of negation</source>
<target state="new">Use subtraction instead of negation</target>
<note />
</trans-unit>
<trans-unit id="FSharpDisposableLocalValuesClassificationType">
<source>F# Disposable Values (locals)</source>
<target state="new">F# Disposable Values (locals)</target>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
<target state="translated">新增 'new' 關鍵字</target>
<note />
</trans-unit>
<trans-unit id="ChangePrefixNegationToInfixSubtraction">
<source>Use subtraction instead of negation</source>
<target state="new">Use subtraction instead of negation</target>
<note />
</trans-unit>
<trans-unit id="FSharpDisposableLocalValuesClassificationType">
<source>F# Disposable Values (locals)</source>
<target state="new">F# Disposable Values (locals)</target>
Expand Down