SynthesizedReadOnlyListTypeSymbol.Create - Check for MissingMetadataTypeSymbol #71330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Compilers
untriaged
ghost
added
the
Community
AlekseyTs
reviewed
Dec 18, 2023
| @@ -102,8 +102,8 @@ internal static NamedTypeSymbol Create(SourceModuleSymbol containingModule, stri | |||
| DiagnosticInfo? diagnosticInfo = null; | |||
|
|
|||
| var hasReadOnlyInterfaces = | |||
| !compilation.IsTypeMissing(SpecialType.System_Collections_Generic_IReadOnlyCollection_T) | |||
| && !compilation.IsTypeMissing(SpecialType.System_Collections_Generic_IReadOnlyList_T); | |||
| compilation.GetSpecialType(SpecialType.System_Collections_Generic_IReadOnlyCollection_T) is not MissingMetadataTypeSymbol && | |||
There was a problem hiding this comment.
compilation.GetSpecialType(SpecialType.System_Collections_Generic_IReadOnlyCollection_T) is not MissingMetadataTypeSymbol &&
It looks like we are fixing a real bug, but not adding any unit-tests. I think we should add a unit-test that makes the problem observable. I.e. a test that fails without the fix. #Closed
|
@AlekseyTs @dotnet/roslyn-compiler this is ready for review. thanks. |
|
@dotnet/roslyn-compiler For the second review |
cston
approved these changes
Dec 19, 2023
|
Thanks @alrz for the contribution. |
333fred
added a commit
to 333fred/roslyn
that referenced
this pull request
Dec 19, 2023
* upstream/main: (79 commits) SynthesizedReadOnlyListTypeSymbol.Create - Check for MissingMetadataTypeSymbol (dotnet#71330) Add comment Make obsolete Update src/Features/CSharp/Portable/SignatureHelp/LightweightOverloadResolution.cs Update tests Update tests Update tests Raw strings File scoped namespaces Add tests Add index check Add tests Docs Simplify Move to top level type Finalize Simplify In progress In progress Do not call Unsubst if it is not available due to argument processing (dotnet#71282) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #71297