Use singular helper when creating checksums #72849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
CyrusNajmabadi
commented
Apr 2, 2024
| @@ -74,6 +74,9 @@ public static Checksum Create(Checksum checksum1, Checksum checksum2) | |||
| public static Checksum Create(Checksum checksum1, Checksum checksum2, Checksum checksum3) | |||
| => Create(stackalloc[] { checksum1, checksum2, checksum3 }); | |||
|
|
|||
| public static Checksum Create(Checksum checksum1, Checksum checksum2, Checksum checksum3, Checksum checksum4) | |||
| => Create(stackalloc[] { checksum1, checksum2, checksum3, checksum4 }); | |||
There was a problem hiding this comment.
needed in linked pr.
CyrusNajmabadi
commented
Apr 2, 2024
| @@ -205,7 +205,7 @@ private IOptionsSerializationService GetOptionsSerializationService(string langu | |||
| => _lazyLanguageSerializationService.GetOrAdd(languageName, n => _workspaceServices.GetLanguageServices(n).GetRequiredService<IOptionsSerializationService>()); | |||
|
|
|||
| public Checksum CreateParseOptionsChecksum(ParseOptions value) | |||
| => Checksum.Create(value, this); | |||
| => Checksum.Create((value, @this: this), static (tuple, writer) => tuple.@this.SerializeParseOptions(tuple.value, writer)); | |||
There was a problem hiding this comment.
no need for the specialized helper for ParseOptions all the way in teh chcksum layer.
CyrusNajmabadi
commented
Apr 2, 2024
| { | ||
| foreach (var checksum in checksums) | ||
| checksum.WriteTo(writer); | ||
| } |
There was a problem hiding this comment.
all these helpers now defer to the helper that takes a callback and passed it an ObjectWriter to write data into (which itself is then checksumed). This is teh same logic as before, just with teh common code of creating the objectwriter and checksum'ing it pushed to the helper.
CyrusNajmabadi
commented
Apr 2, 2024
| return Create(stream); | ||
| } | ||
|
|
||
| public static Checksum Create(ParseOptions value, ISerializerService serializer) |
There was a problem hiding this comment.
this helper went away entirely. the one place that was calling it just inlined its behavior at the callsite.
This was referenced Apr 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #72494.