Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use singular helper when creating checksums #72849

Merged
merged 4 commits into from
Apr 2, 2024
Merged

Use singular helper when creating checksums #72849

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5f98812
Use singular helper when creating checksumsw
CyrusNajmabadi Apr 2, 2024
0afa747
Use singular helper when creating checksumsw
CyrusNajmabadi Apr 2, 2024
3b0fe27
Downstream
CyrusNajmabadi Apr 2, 2024
307d04a
Add test
CyrusNajmabadi Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use singular helper when creating checksumsw
  • Loading branch information
@CyrusNajmabadi
CyrusNajmabadi committed Apr 2, 2024
commit 0afa747a0838d22f25b258172a4173c5aa022074
26 changes: 13 additions & 13 deletions src/Workspaces/Core/Portable/Workspace/Solution/Checksum_Factory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,19 @@ public static Checksum Create(Stream stream)
return From(hash);
}

public static Checksum Create<T>(T @object, Action<T, ObjectWriter> writeObject)
{
using var stream = SerializableBytes.CreateWritableStream();

using (var objectWriter = new ObjectWriter(stream, leaveOpen: true))
{
writeObject(@object, objectWriter);
}

stream.Position = 0;
return Create(stream);
}

public static Checksum Create(Checksum checksum1, Checksum checksum2)
=> Create(stackalloc[] { checksum1, checksum2 });

Expand Down Expand Up @@ -104,17 +117,4 @@ public static Checksum Create<T>(T value, ISerializerService serializer)
serializer.Serialize(value!, writer, context, CancellationToken.None);
});
}

public static Checksum Create<T>(T value, Action<T, ObjectWriter> writeTo)
{
using var stream = SerializableBytes.CreateWritableStream();

using (var objectWriter = new ObjectWriter(stream, leaveOpen: true))
{
writeTo(value, objectWriter);
}

stream.Position = 0;
return Create(stream);
}
}
Loading