-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crossgen2 comp jobs #52949
Fix crossgen2 comp jobs #52949
Conversation
… methods - Remove logic in MethodBuild that disallows static abstract methods - Add support in interface map for finding static virtuals, and enumerating them - Add tests
…ugging build time failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me, thank you!
python3 -u $HELIX_CORRELATION_PAYLOAD/crossgen2_comparison.py crossgen_framework | ||
--crossgen $HELIX_WORKITEM_PAYLOAD/crossgen2/crossgen2.dll | ||
--dotnet $HELIX_WORKITEM_PAYLOAD/corerun | ||
--core_root $HELIX_WORKITEM_PAYLOAD/prebuiltWork/dlls | ||
--result_dir $HELIX_WORKITEM_PAYLOAD/log | ||
--target_os $(target_crossgen2_os) | ||
--target_arch $(targetarch); | ||
--target_arch $(targetarch) | ||
--compiler_arch_os $(compiler_arch_os); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the semicolon appropriate here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Its the separator between different commands in bash. Just like the '&' for cmd scripts below.
There were several problems with running these tests
There remains some evidence that the behavior is still a bit flaky, but the last test pass was completely green.