Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crossgen2 comp jobs #52949

Merged
merged 14 commits into from
May 20, 2021
Merged

Fix crossgen2 comp jobs #52949

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
92a6a31
Add support in Reflection.Emit and GetInterfaceMap for static virtual…
davidwrighton May 17, 2021
6141873
Disable tests on Mono
davidwrighton May 17, 2021
7636cb3
Merge branch 'main' of github.com:dotnet/runtime into fix_crossgen2_c…
davidwrighton May 18, 2021
6124fc6
Remove experimental utf8 dll from list of dlls to compile
davidwrighton May 18, 2021
de50a8b
Update PR build template to just to crossgen2_comparison jobs
davidwrighton May 18, 2021
9b11dd9
Remove evaluate paths
davidwrighton May 18, 2021
dd79969
Seems like thats actually needed for some reason
davidwrighton May 18, 2021
899d531
Fix CORE_ROOT and add testResults support for better test diagnostics
davidwrighton May 19, 2021
5f4ce4c
Fix typo
davidwrighton May 19, 2021
077031d
Fix polarity on failure check in testresults generation
davidwrighton May 19, 2021
bed2e1f
Fix CORE_ROOT variable and print out stdout and stderr for better deb…
davidwrighton May 19, 2021
ba1596a
Add prefix to compile tests so that what they are is easier to unders…
davidwrighton May 19, 2021
ee464c6
Put old runtime.yml back
davidwrighton May 19, 2021
4799cc8
Put old runtime.yml back take 2
davidwrighton May 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Disable tests on Mono
  • Loading branch information
@davidwrighton
davidwrighton committed May 17, 2021
commit 61418731c2720f17eff7167f4ab45c865acf9e5f
2 changes: 2 additions & 0 deletions src/libraries/System.Reflection.Emit/tests/TypeBuilder/TypeBuilderDefineMethodOverride.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ public interface InterfaceWithMethod
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/49904", TestRuntimes.Mono)]
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Static virtual interface methods not supported on .NET Framework")]
public void DefineMethodOverride_StaticVirtualInterfaceMethod()
{
Expand All @@ -294,6 +295,7 @@ public void DefineMethodOverride_StaticVirtualInterfaceMethod()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/49904", TestRuntimes.Mono)]
[SkipOnTargetFramework(TargetFrameworkMonikers.NetFramework, "Static virtual interface methods not supported on .NET Framework")]
public void DefineMethodOverride_StaticVirtualInterfaceMethod_VerifyWithInterfaceMap()
{
Expand Down