-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move GreaterThan2GBFile_SendsAllBytes to a non-parallel test collection #57946
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #57907 Intentionally left out
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
// Running all cases of GreaterThan2GBFile_SendsAllBytes in parallel may attempt to allocate Min(ProcessorCount, Subclass_Count) * 2GB of disk space | ||
// in extreme cases. Some CI machines may run out of disk space if this happens. | ||
[Collection(nameof(NoParallelTests))] | ||
public class SendFile_NonParallel<T> : SocketTestHelperBase<T> where T : SocketHelperBase, new() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abstract?
public sealed class SendFile_NonParallel_Apm : SendFile_NonParallel<SocketHelperApm> | ||
{ | ||
public SendFile_NonParallel_Apm(ITestOutputHelper output) : base(output) { } | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that SocketHelperCancellableTask
and SocketHelperSyncForceNonBlocking
are left out on purpose?
I should have read the description first 😄
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1161691277 |
Fixes #57907
Intentionally left out
***CancellableTask
and***SyncForceNonBlocking
to somewhat counterpart the increased execution time. I don't think we need all the cases for this particular test.