Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SendFile_NonParallel<T> abstract #58003

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Aug 24, 2021

Minor, but important addition to #57946, test base class should have been made abstract, without that tests are failing.

Fixes #57907

/cc @ManickaP

@ghost
Copy link

ghost commented Aug 24, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Minor, but important addition to #57946, test base class should have been made abstract.

/cc @ManickaP

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Sockets

Milestone: -

@antonfirsov
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@karelz
Copy link
Member

karelz commented Aug 24, 2021

Hitting unrelated test failures:

Re-running failing legs

@antonfirsov
Copy link
Member Author

We are still hitting external outages with HttpClientHandler_RemoteServerTest, which is unrelated.

@antonfirsov antonfirsov merged commit 0d3ce71 into main Aug 24, 2021
@akoeplinger akoeplinger deleted the antonfirsov/SendFile_NonParallel-abstract branch August 28, 2021 22:04
@ghost ghost locked as resolved and limited conversation to collaborators Sep 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure System.Net.Sockets.Tests.SendFile_CancellableTask.GreaterThan2GBFile_SendsAllBytes
3 participants