Make Type.IsEnum and Type.GetEnumUnderlyingType intrinsics #71685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes Type.GetTypeCode a JIT intrinsic for primitive types, enums and strings. Makes Type.IsEnum use intrinsics instead of IsSubclassOf Makes Enum.GetUnderlyingType use Type.GetTypeCode Moves the legacy FCall to InternalGetUnderlyingTypeImpl, so that the non-intrinsic GetTypeCode can use it. Introduces JIT tests checking the generated codegen.
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch Issue DetailsMakes Type.GetTypeCode a JIT intrinsic for primitive types, Makes Type.IsEnum use intrinsics instead of IsSubclassOf Makes Enum.GetUnderlyingType use Type.GetTypeCode Moves the legacy FCall to InternalGetUnderlyingTypeImpl, Introduces JIT tests checking the generated codegen. Fixes #70483.
|
MichalPetryka
commented
Jul 5, 2022
jkotas
reviewed
Jul 5, 2022
|
This PR generates the desired codegen only with #71778. |
MichalPetryka
changed the title
AndyAyersMS
reviewed
Jul 9, 2022
| // Return Value: | ||
| // Is the tree typeof() | ||
| // | ||
| bool Compiler::gtIsTypeof(GenTree* tree, CORINFO_CLASS_HANDLE* handle) |
There was a problem hiding this comment.
Seems like you should try and leverage gtGetTypeProducerKind and/or gtIsTypeHandleToRuntimeTypeHelper here.
There was a problem hiding this comment.
gtGetTypeProducerKind doesn't seem particularly useful here since we don't know the exact type with .GetType() and we don't want to return null types here so I've used gtIsTypeHandleToRuntimeTypeHelper and added tests for NRE with Type.GetTypeFromHandle(default) (which I assume generates the (actually only __reftype seems to generate it)._MAYBENULL helper variant)
|
Yes, I think it is okay to have that method in Type.cs. Nit: I would call the method |
vargaz
reviewed
Nov 1, 2022
vargaz
added a commit
to vargaz/runtime
that referenced
this pull request
Nov 2, 2022
… parameters. Related: dotnet#71685.
|
#77763 will fix the mono failures. |
|
@MichalPetryka Could you please merge from main and resolve the conflicts? |
|
@jkotas |
Do you have #77715 ? |
Yes. For context: |
|
For now I've worked around it by disabling TreatWarningsAsErrors in the generator. |
|
@jkotas Is there anything left to be done here on my part? |
jkotas
reviewed
Nov 5, 2022
...ries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Nov 5, 2022
...ries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Nov 5, 2022
...ries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Nov 5, 2022
...ries/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentDictionary.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Nov 10, 2022
...raries/System.Text.Json/src/System/Text/Json/Serialization/Converters/Value/EnumConverter.cs
Outdated
Show resolved
Hide resolved
…ion/Converters/Value/EnumConverter.cs
jkotas
reviewed
Nov 10, 2022
jkotas
approved these changes
Nov 10, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes Type.IsEnum and Type.GetEnumUnderlyingType intrinsics.
Implements IsKnownConstant for Type.
Optimizes Type.GetTypeCode using IsKnownConstant.
Introduces a JIT helper for checking if a tree is typeof.
Introduces JIT tests checking the generated codegen.