Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Type.IsEnum and Type.GetEnumUnderlyingType intrinsics #71685

Merged
merged 59 commits into from
Nov 11, 2022
Merged

Make Type.IsEnum and Type.GetEnumUnderlyingType intrinsics #71685

Changes from 1 commit
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
2744c1c
Make Type.GetTypeCode an intrinsic
MichalPetryka Jul 5, 2022
f20053b
Change IsEnum to an intrinsic
MichalPetryka Jul 6, 2022
195bad6
Fix formatting
MichalPetryka Jul 6, 2022
f60efb6
Fix formatting 2
MichalPetryka Jul 6, 2022
4317f2d
Formatting fix 3
MichalPetryka Jul 6, 2022
616be5d
Fix test
MichalPetryka Jul 6, 2022
dff9f04
Fallback to the FCall for nint/nuint enums
MichalPetryka Jul 6, 2022
6959e90
Fix compilation
MichalPetryka Jul 6, 2022
c27672c
Add missing Intrinsic
MichalPetryka Jul 6, 2022
1745d84
Fix void handling
MichalPetryka Jul 7, 2022
509842b
Fix compilation
MichalPetryka Jul 7, 2022
e1300f4
Fix formatting
MichalPetryka Jul 7, 2022
94f19da
Add typeof support to IsKnownConstant
MichalPetryka Jul 8, 2022
b07b12f
Merge branch 'main' into enum-underlyingtype
MichalPetryka Jul 8, 2022
c3dc12f
Move the helper
MichalPetryka Jul 8, 2022
eb0bc1b
Add missing break
MichalPetryka Jul 8, 2022
098d472
Revert some changes, simplify code
MichalPetryka Jul 9, 2022
f05b1b2
Use gtIsTypeHandleToRuntimeTypeHelper
MichalPetryka Jul 10, 2022
02cd252
Fix test
MichalPetryka Jul 10, 2022
753dca2
Add __reftype tests
MichalPetryka Jul 10, 2022
b5a2c78
Merge remote-tracking branch 'original/main' into enum-underlyingtype
MichalPetryka Jul 10, 2022
a65d81c
Make more places use gtIsTypeof
MichalPetryka Jul 10, 2022
9f1eb3e
Fix tests
MichalPetryka Jul 10, 2022
4f99338
Move the IsEnum check
MichalPetryka Jul 10, 2022
d2957e7
Update EnumTests.cs
MichalPetryka Jul 10, 2022
791476b
Apply suggestions, add more tests
MichalPetryka Jul 13, 2022
1f2bf41
Add impTypeGetTypeCode to the header
MichalPetryka Jul 13, 2022
d0769b9
Fix formatting
MichalPetryka Jul 13, 2022
2a121d5
Update EnumGetUnderlyingTypeEnums.il
MichalPetryka Jul 13, 2022
9ffdf78
Merge remote-tracking branch 'original/main' into enum-underlyingtype
MichalPetryka Jul 14, 2022
efc9f64
Make the IsActualEnum helper an intrinsic
MichalPetryka Jul 14, 2022
0b3b868
Update EnumGetUnderlyingType.cs
MichalPetryka Jul 14, 2022
9d8b3c6
Fix tests
MichalPetryka Jul 23, 2022
559c815
Merge branch 'main' into enum-underlyingtype
MichalPetryka Aug 19, 2022
7edab59
Merge remote-tracking branch 'original/main' into enum-underlyingtype
MichalPetryka Sep 1, 2022
f2ec8a9
Remove GetTypeCode intrinsics
MichalPetryka Sep 1, 2022
245098c
Merge
MichalPetryka Oct 28, 2022
1a609d1
Create a new JIT-EE api, add GetEnumUnderlyingType back
MichalPetryka Oct 30, 2022
a1291e7
Fix formatting
MichalPetryka Oct 30, 2022
2f17cda
Apply suggestions
MichalPetryka Oct 30, 2022
3e1e52e
Revert unnecessary whitespace
MichalPetryka Oct 30, 2022
e519f0c
Optimize GetTypeCode with IsKnownConstant
MichalPetryka Oct 30, 2022
6d5e308
Fix typo
MichalPetryka Oct 30, 2022
9c70c8f
Change the code to make the inliner happy
MichalPetryka Oct 30, 2022
40a349a
Handle all types in GetTypeCode
MichalPetryka Oct 30, 2022
846e57c
Check for custom types
MichalPetryka Oct 31, 2022
159f147
Apply suggestions from code review
MichalPetryka Oct 31, 2022
c0d9dea
Fix build, do suggested changes
MichalPetryka Oct 31, 2022
b8be7f2
Remove accidental edit
MichalPetryka Oct 31, 2022
7664920
Fix build
MichalPetryka Oct 31, 2022
30afabc
Fix build
MichalPetryka Oct 31, 2022
3e14c6e
Fix build
MichalPetryka Oct 31, 2022
d57b8ae
Fix NativeAOT build
MichalPetryka Nov 1, 2022
ee8ce1d
Merge
MichalPetryka Nov 3, 2022
d2d72df
Remove merge leftovers
MichalPetryka Nov 3, 2022
c1b3bf2
Fix generated files
MichalPetryka Nov 3, 2022
64def53
Revert changes in non CoreCLR specific code
MichalPetryka Nov 10, 2022
28561ac
Update src/libraries/System.Text.Json/src/System/Text/Json/Serializat…
jkotas Nov 10, 2022
9f108e9
Update src/libraries/System.Private.CoreLib/src/System/Enum.cs
jkotas Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add missing break
  • Loading branch information
@MichalPetryka
MichalPetryka committed Jul 8, 2022
commit eb0bc1ba0c1373144631f10b94d41bf1d6b3d68b
1 change: 1 addition & 0 deletions src/coreclr/jit/importer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4230,6 +4230,7 @@ GenTree* Compiler::impIntrinsic(GenTree* newobjThis,
impPopStack();
}
}
break;
}

case NI_System_Threading_Thread_get_ManagedThreadId:
Expand Down