-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typo in MULTIPLE_HEAPS to fix a memory usage regression #73275
Conversation
Tagging subscribers to this area: @dotnet/gc Issue DetailsMisspelt
|
Memory Regression is fixed:
Using:
And the microbenchmark hasn't regressed:
|
can you also take the opportunity to fix the other issue I mentioned "it needs to initialize the saved_allocated in the else case when shigh is 0."? |
I think I have already fixed it. Please let me know if I got it wrong:
|
it's correct. the change just wasn't there when I reviewed it the first time (I saw you did this in a separate commit). |
Misspelt
MULTIPLE_HEAPS
- fixes #73254.