Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in MULTIPLE_HEAPS to fix a memory usage regression #73275

Merged
merged 2 commits into from
Aug 3, 2022
Merged

Typo in MULTIPLE_HEAPS to fix a memory usage regression #73275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ac511d
Typo fix to solve memory regression
mrsharm Aug 2, 2022
7029fb0
Fix initialization of heap_segment_saved_allocated if shigh == 0
mrsharm Aug 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/coreclr/gc/gc.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28245,9 +28245,9 @@ void gc_heap::add_plug_in_condemned_info (generation* gen, size_t plug_size)

inline void save_allocated(heap_segment* seg)
{
#ifndef MULTIPLE_HEAP
#ifndef MULTIPLE_HEAPS
if (!heap_segment_saved_allocated(seg))
#endif // !MULTIPLE_HEAP
#endif // !MULTIPLE_HEAPS
{
heap_segment_saved_allocated (seg) = heap_segment_allocated (seg);
}
Expand Down Expand Up @@ -28421,6 +28421,7 @@ void gc_heap::plan_phase (int condemned_gen_number)
heap_segment* sseg = seg;
do
{
heap_segment_saved_allocated(seg) = 0;
uint8_t* start_unmarked = heap_segment_mem (seg);
#ifndef USE_REGIONS
// shorten it to minimum
Expand Down