-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ability to set GCName via runtimeconfig. #74831
Conversation
@mrsharm, shall we update the behavior of the |
Sure - will work on this. |
There is a CI issue which is blocking re-running the wasm leg. It had passed on the previous run so this should be good to merge. Please CR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'll be following this PR up with updating our GC Configs so that this configuration shows up in our GetConfigurationVariables
API.
I plan to backport this to 7, would the API change require porting to 7 as well? |
Since the change will be a trivial and risk-free one, I think we could add the changes to gcconfig.h in one PR i.e. for the backport, merge the changes from this PR and the one I plan to create (which should be a few lines only). |
Added the new config to
|
/backport to release/7.0 |
Started backporting to release/7.0: https://github.com/dotnet/runtime/actions/runs/3002894605 |
gcname was only enabled via
DOTNET_GCName
, this change enables setting it viaSystem.GC.GCName
in runtimeconfig.json.